831485 - _virtualenv and mozilla/_virtualenv in each c-c objdir

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[[e-mail]]

c-c configure adds _virtualenv to the objdir and then m-c configure adds it to its objdir/mozilla subdir. We can avoid the duplication by making c-c configure build objdir/mozilla/_virtualenv directly.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 703021 [details] [diff] [review]
Proposed patch

Review of attachment 703021 [details] [diff] [review]:
-----------------------------------------------------------------

I'd actually prefer you modify http://mxr.mozilla.org/comm-central/source/mozilla/build/autoconf/python-virtualenv.m4#50 (get m-c build peer review) and then use that here, the same way its used in m-c configure. Also to mark the creation script as a config dep in client.mk.

We can then even output the NO_POPULATE var to save work. The trick of course is making sure comm can find the venv inside m-c easily :-)

Comment 3

[[e-mail]]

(In reply to Justin Wood from comment #2)
> I'd actually prefer you modify
> http://mxr.mozilla.org/comm-central/source/mozilla/build/autoconf/python-
> virtualenv.m4#50 (get m-c build peer review) and then use that here, the
> same way its used in m-c configure.
Ah, so you want me to include that script in c-c aclocal.m4?

> Also to mark the creation script as a config dep in client.mk.
We don't actually do that, we only mark aclocal.m4 as a config dep...

> We can then even output the NO_POPULATE var to save work. The trick of
> course is making sure comm can find the venv inside m-c easily :-)
I guess I'll just make c-c configure set MOZILLA_CENTRAL_PATH.

Comment 4

[[e-mail]]

Attachment: Possible patch

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 708278 [details] [diff] [review]
Possible patch

Review of attachment 708278 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like that should work.

Comment 6

[[e-mail]]

Pushed comm-central changeset fb586ffef6e8.

Comment 7

[Frank Wein [:mcsmurf]]

Does this checkin have to do with the current red on the SeaMonkey tree? It looks a bit related.