Closed
Bug 831629
Opened 11 years ago
Closed 11 years ago
Add 291 missing jit-tests for various fixed JS bugs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: decoder, Assigned: decoder)
Details
Attachments
(1 file, 2 obsolete files)
153.14 KB,
patch
|
decoder
:
review+
|
Details | Diff | Splinter Review |
The attached patch adds 291 jit-tests to the testsuite. These tests were automatically extracted from a list of fixed JS bugs that do have tests in the bugs but not in testsuite. The automation ensured that the bug reproduced on the original revision and also generated appropriate jit-test tags for all bugs. Only in a few cases, manual interaction was required to rewrite some tests. This is part of a QA effort to bring down the number of fixed JS bugs that don't have tests checked in. I also checked how much longer jit-tests take now: With 8 parallel jobs and a hybrid (debug+opt) shell, the tests run in roughly a minute with tbpl options.
Attachment #703145 -
Flags: review?(terrence)
Comment 1•11 years ago
|
||
Comment on attachment 703145 [details] [diff] [review] Patch Review of attachment 703145 [details] [diff] [review]: ----------------------------------------------------------------- The ones I spot-checked all look fine and like good tests to have. rs=me
Attachment #703145 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Patch v2. Fixed a few nits that caused try to go orange (some debug-only functions used, some tests behaving different on windows). Keeping r+ and landing in a few.
Assignee: general → choller
Attachment #703145 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #703893 -
Flags: review+
Assignee | ||
Comment 3•11 years ago
|
||
Now with the right attachment even \o/
Attachment #703893 -
Attachment is obsolete: true
Attachment #703894 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/efaf8960a929
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/efaf8960a929 \o/ \o/ \o/ \o/ \o/
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•