Closed Bug 831757 Opened 11 years ago Closed 11 years ago

Click-to-play: Using history.pushState() makes plugin icon in the location bar vanish

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(firefox20 verified, firefox-esr17- affected)

VERIFIED FIXED
mozilla21
Tracking Status
firefox20 --- verified
firefox-esr17 - affected

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [CtPUR:+] [CtPDefault:P2] fixed by bug 825804)

Attachments

(3 files, 1 obsolete file)

When using history.pushState(), the click-to-play plugin icon vanishes from the URL bar even though there still are embed/object elements.

This affects e.g. SoundCloud which seems to have recently switched to using pushState.
Attached file test case
What SeaMonkey does looks cleaner to me and fixes this case.
I think bug 788584 was going to do this, but we never got around to it :-/
The change suggested by bug 788584 doesn't fix the vanishing icon, but i guess both could be fixed in one go.
Attachment #703445 - Attachment is obsolete: true
This still fails test 4 in browser_popupNotification.js, for which i don't know off-hand what's happing:
https://tbpl.mozilla.org/?tree=Try&rev=8da1a4339b83
Assignee: nobody → georg.fritzsche
Whiteboard: [CtPUR:+]
Whiteboard: [CtPUR:+] → [CtPUR:+] [CtPDefault:P2]
Was this fixed by bug 825804?
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #7)
> Was this fixed by bug 825804?

Yeah, should be fixed.
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 825804
Resolution: --- → FIXED
Whiteboard: [CtPUR:+] [CtPDefault:P2] → [CtPUR:+] [CtPDefault:P2] fixed by bug 825804
Target Milestone: --- → mozilla21
Verified fixed FF 20.0a2 (2013-02-18) Win 7
Status: RESOLVED → VERIFIED
We'll track bug 825804 for ESR.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: