Closed Bug 832104 Opened 11 years ago Closed 11 years ago

Don't report CSS errors in production builds r=cjones

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18+ fixed)

Status:
RESOLVED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 + fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
1008 bytes, patch
cjones
: review+
akeybl
: approval-mozilla-b2g18+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
mfinkle reports a 9% improvement in Tp4 on fennec with that change. I only turned it on in prod builds so gaia developers can still get their error logs :)
Attachment #703687 - Flags: review?(jones.chris.g)
blocking-b2g: --- → tef?
Assignee: nobody → fabrice
Attachment #703687 - Flags: review?(jones.chris.g) → review+
Comment on attachment 703687 [details] [diff] [review]
patch

Actually, can we make this a setting enabled along with the current logging setting in the gaia UI?  We want developers to see these.
Attachment #703687 - Flags: review+
Attached patch patch v2 — — Splinter Review 
Yep, that makes sense!
Attachment #703687 - Attachment is obsolete: true
Attachment #703710 - Flags: review?(jones.chris.g)
Comment on attachment 703710 [details] [diff] [review]
patch v2

<3
Attachment #703710 - Flags: review?(jones.chris.g) → review+
Wouldn't block on this but a trivial pref change that's been validated on fennec to be a 10% load-time improvement is something I would approve in a heartbeat.
blocking-b2g: tef? → -
tracking-b2g18: --- → +
Comment on attachment 703710 [details] [diff] [review]
patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: we won't get a 10% page load win
Testing completed: 
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none
Attachment #703710 - Flags: approval-mozilla-b2g18?
Comment on attachment 703710 [details] [diff] [review]
patch v2

Approving for v1.0.0 (mozilla-b2g18 tip) given the risk/reward here.
Attachment #703710 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/8dbc4068419a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-b2g18: --- → fixed
status-firefox19: --- → wontfix
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
Target Milestone: --- → B2G C4 (2jan on)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: