832234 - Resume behaves like step-out after a step-in

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

STR: 

1. Open debugger on http://htmlpad.org/step-out-vs-resume/
2. Add a breakpoint on line 18
3. Click me
4. Step in
5. Resume

Debugger pauses on line 19. I'd expect it to resume and finish executing all the scripts, since there's no other breakpoint set.

Comment 2

[Shane Tomlinson [:stomlinson]]

Thanks :vp, I'll keep my eye on 890863

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Clear any previous stepping hooks on a plain resumption

I thought about this yesterday on the beach and the fix was rather simple. I still need to write a test and fix a broken one (test_blackboxing-01.js)

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Clear any previous stepping hooks on a plain resumption

We had a number of workarounds in a couple of our tests to avoid this issue, which I removed, and they can now serve as a test for the new correct behavior. Let me know if you would prefer a separate test for this change though.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 776241 [details] [diff] [review]
Clear any previous stepping hooks on a plain resumption

Review of attachment 776241 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +417,5 @@
> +      // Clear any previous stepping hooks on a plain resumption.
> +      let frame = this.youngestFrame;
> +      while (frame) {
> +        frame.onStep = undefined;
> +        frame.onPop = undefined;

do you like this better than delete? I suppose this way the properties stick around.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> ::: toolkit/devtools/server/actors/script.js
> @@ +417,5 @@
> > +      // Clear any previous stepping hooks on a plain resumption.
> > +      let frame = this.youngestFrame;
> > +      while (frame) {
> > +        frame.onStep = undefined;
> > +        frame.onPop = undefined;
> 
> do you like this better than delete? I suppose this way the properties stick
> around.

That's right, I tried to make sure that the shape of the object wouldn't change. I'm not sure it matters much in this case, but it's a habit I've developed :-)

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/2327af3c6f07

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2327af3c6f07