832272 - To allow parallel build of nss

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

This patch allows me to build NSS by parallel.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Martin Stránský from comment #0)
> Created attachment 703856 [details] [diff] [review]
> patch
> 
> This patch allows me to build NSS by parallel.

Does this work when building NSS outside the mozilla tree?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Have not tried, I use it for building trunk with in-tree nss.

Comment 3

[Honza Bambas (:mayhemer)]

Seems like it doesn't work for standalone NSS :(

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Honza, do you build on Linux or Windows? Which build failures do you get? I guess it could be adapted for standalone NSS.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: build-log

(In reply to Martin Stránský from comment #4)
> Honza, do you build on Linux or Windows? Which build failures do you get? I
> guess it could be adapted for standalone NSS.

I'm using following build commands:
OS_TARGET=WINNT
BUILD_OPT=1
cd mozilla/security/nss
pymake nss_build_all (-j9)

win7, 1.6.1 mozilla-build, using VC10.

pymake nss_build_all: following non-critical errors, the build actually succeeds!:

Error executing command ../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../../config/./now [Error 2] The system cannot find the file specified
Error executing command ../../../config/./now [Error 2] The system cannot find the file specified

pymake nss_build_all -j9: build fails and see the attachment for a complete log build (win stdout)

Comment 6

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Comment 7

[Mike Hommey [:glandium]]

Attachment: Avoid certdata.c being created before $(OBJDIR) is

Comment 8

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Comment 9

[Kai Engert (:KaiE:)]

Comment on attachment 707044 [details] [diff] [review]
Avoid certdata.c being created before $(OBJDIR) is

seems reasonable! r=kaie

Comment 10

[Kai Engert (:KaiE:)]

(In reply to Honza Bambas (:mayhemer) from comment #5)
> 
> I'm using following build commands:
> OS_TARGET=WINNT

Honza, note that WINNT is an older configuration that has problems.
The more modern config is named WIN95, and WIN95 is being used by Firefox.

Comment 11

[Mike Hommey [:glandium]]

(In reply to Kai Engert (:kaie) from comment #9)
> Comment on attachment 707044 [details] [diff] [review]
> Avoid certdata.c being created before $(OBJDIR) is
> 
> seems reasonable! r=kaie

Could you land it in NSS?

Comment 12

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

This is a more elaborate version, which doesn't need any nss change, and that prepares things for bug 648407.

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 710209 [details] [diff] [review]
Allow mostly parallel build of NSS

Must have forgotten to fold something in this patch...

Comment 14

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

This passes try ; i'll send another try with PGO enabled, though.

Comment 15

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Only changes some variable names.

Comment 16

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Sorry for the noise ; added a comment about the private_export thing.

Comment 17

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Just changed paths for the DLLs (dist/bin instead of dist/lib)

Comment 18

[Mike Hommey [:glandium]]

Comment on attachment 711259 [details] [diff] [review]
Allow mostly parallel build of NSS

Grah, it's broken

Comment 19

[Mike Hommey [:glandium]]

Attachment: Allow mostly parallel build of NSS

Comment 20

[(not currently active) Ted Mielczarek]

Comment on attachment 711316 [details] [diff] [review]
Allow mostly parallel build of NSS

Review of attachment 711316 [details] [diff] [review]:
-----------------------------------------------------------------

I assume your intention is to remove these workarounds once real fixes land?

I don't love this, but the payoff is nice. Hopefully the NSS build system will be improved and we won't have to work around it so much.

Comment 21

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e81aef9e0d16

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e81aef9e0d16

Comment 23

[Wan-Teh Chang]

Comment on attachment 707044 [details] [diff] [review]
Avoid certdata.c being created before $(OBJDIR) is

https://hg.mozilla.org/projects/nss/rev/514f784e0402