Closed Bug 832559 Opened 11 years ago Closed 11 years ago

Remove clear all from pinned sites menu

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(firefox21 verified)

VERIFIED FIXED
Firefox 21
Tracking Status
firefox21 --- verified

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file)

This isn't that useful and clutters up an already confusing interface. We're going to remove it. Patch coming...
Attached patch PatchSplinter Review
Assignee: nobody → wjohnston
Attachment #704154 - Flags: review?(mark.finkle)
Attachment #704154 - Flags: review?(mark.finkle) → review+
Comment on attachment 704154 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 783312
User impact if declined: Extra clutter in menus
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Very small simple patch. Low risk.
String or UUID changes made by this patch: Removes some strings that are no longer needed.
Attachment #704154 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/cbd8737f179c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
looping Axel in on this bug since approving an uplift, even for removing strings, breaks string freeze.  If this can't ride the trains we'll need Axel's recommendation on what to do here.
We can remove the UI items but leave the strings.
(In reply to Mark Finkle (:mfinkle) from comment #6)
> We can remove the UI items but leave the strings.

That sounds good, yes.
Comment on attachment 704154 [details] [diff] [review]
Patch

Sounds good, please provide an updated patch for uplift nom.
Attachment #704154 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Option was removed from the latest Nightly. Closing bug as verified fixed on:

Firefox for Android
Version: 21.0a1 (2013-01-29)
Device: Galaxy R
OS: Android 2.3.4
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: