832900 - Make test layout/mathml/tests/stretchy-and-large-operators.html work

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

layout/mathml/tests/stretchy-and-large-operators.html is an exhaustive test for the stretchy and large operators from our operator dictionary. However is does not work at the moment, because it incorrectly creates MathML elements with the createElement() function. The function createElementNS() (with the MathML namespace) should be used instead.

(See bug 755541 and 832713 comment 3)

Comment 1

[Sunny [:darkowlzz]]

Attachment: Made changes as per the comment

Comment 2

[Frédéric Wang (:fredw)]

Thanks, that look good. I would put the MathML namespace string in a global variable rather than repeating it everywhere, but that's OK.

Be sure to try to conform to Mozilla's style guides: 80-character lines and a space after the commas.
(https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide)

For the commit message, see a model here:
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Commit_message_restrictions

Comment 3

[Sunny [:darkowlzz]]

Attachment: Made changes as per the comment

Made some changes.
Created a global variable to supply namespace to all the creation code.

Comment 4

[Sunny [:darkowlzz]]

Attachment: Made changes as per the comment

Added Bug number in commit message

Comment 5

[Frédéric Wang (:fredw)]

Comment on attachment 705011 [details] [diff] [review]
Made changes as per the comment

That looks good, thanks!

Comment 6

[Frédéric Wang (:fredw)]

Comment on attachment 705011 [details] [diff] [review]
Made changes as per the comment

I don't have commit access. But I put the checkin-needed keyword, so someone will take care of that relatively soon.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36477d961bf2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36477d961bf2