832950 - Consider removing frame annotations

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

bholley says he removed the last use of frame annotations in Gecko a while ago. Frame annotations complicate baseline compiler work, so it would be nice if we could remove them.

David, Luke, any thoughts on this, especially from a JSAPI point-of-view?

Comment 1

[Luke Wagner [:luke]]

Fire ze missiles!  We've been wanting to do this forever (bug 546848).

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Luke Wagner [:luke] from comment #1)
> Fire ze missiles!  We've been wanting to do this forever (bug 546848).

Great! Taking.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 704590 [details] [diff] [review]
Patch

r+ with prejudice (and with much love for bholley).

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

\o/

Comment 6

[Bobby Holley (:bholley)]

(In reply to Luke Wagner [:luke] from comment #4)
> r+ with prejudice (and with much love for bholley).

<3

Comment 7

[Jan de Mooij [:jandem]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8116ecda192a

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/8116ecda192a