833392 - Send RP ID within mozChromeEvents

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

This is the identity counterpart of Bug 832951.

More info at https://bugzilla.mozilla.org/show_bug.cgi?id=832948#c0

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 704964 [details] [diff] [review]
v1

Review of attachment 704964 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/SignInToWebsite.jsm
@@ +180,5 @@
>        let detail = {
>          type: kReceivedIdentityAssertion,
>          showUI: aGaiaOptions.showUI || false,
> +        id: kReceivedIdentityAssertion + "-" + uuid,
> +        requestId: aRpOptions.id 

oops, white space, I'll remove it from the final version.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 704964 [details] [diff] [review]
v1

r=me!  And the corresponding gaia patch is lovely.  As soon as this lands, we can go ahead and merge that.

Thanks for your work on this,
j

Comment 4

[Jason Smith [:jsmith]]

Triage is a bit puzzled on this one. Can this actually reproduce with our v1 requirements? We only have one payment flow for v1.

How would I reproduce this with our existing v1 constraints? Can you explain a bit more?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

This bug is a dependency for bug 832948 so the same reply at https://bugzilla.mozilla.org/show_bug.cgi?id=832948#c8 applies here.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Thanks Jed!

https://hg.mozilla.org/integration/mozilla-inbound/rev/61f5684286e6

Comment 7

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I see the counterpart bug 832951 has already landed in b2g18.  Do we need to set any additional flags on this for it to get the same treatment?

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/491dd35f1ca8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61f5684286e6

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.