Closed
Bug 833882
Opened 11 years ago
Closed 11 years ago
en-US dictionaries and searchplugins are shipped in l10n repacks
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
3.05 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
This changes how l10n-repack handles non chrome directories, such that files with the same name are replaced, files only in l10n are added, and files only in the original build are removed.
Attachment #705510 -
Flags: review?(gps)
Comment 2•11 years ago
|
||
Comment on attachment 705510 [details] [diff] [review] Correctly handle non chrome directories when doing l10n-repack Review of attachment 705510 [details] [diff] [review]: ----------------------------------------------------------------- Just some style nits. ::: toolkit/mozapps/installer/l10n-repack.py @@ +125,5 @@ > for e in [e for e in f if e.localized]: > f.remove(e) > + if p in paths: > + path = paths[p] > + if path: path = p.paths.get(p, None) if path: @@ +132,2 @@ > files = [f for p, f in l10n_finder.find(path)] > + if len(files) == 0: if not len(files) @@ +132,3 @@ > files = [f for p, f in l10n_finder.find(path)] > + if len(files) == 0: > + if not base in NON_CHROME: if base not in NON_CHROME:
Attachment #705510 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #2) > Comment on attachment 705510 [details] [diff] [review] > Correctly handle non chrome directories when doing l10n-repack > > Review of attachment 705510 [details] [diff] [review]: > ----------------------------------------------------------------- > > Just some style nits. > > ::: toolkit/mozapps/installer/l10n-repack.py > @@ +125,5 @@ > > for e in [e for e in f if e.localized]: > > f.remove(e) > > + if p in paths: > > + path = paths[p] > > + if path: > > path = p.paths.get(p, None) > if path: Note that paths[p] == None is treated differently from p not in paths.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c8d59b07d16
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Assignee | ||
Comment 5•11 years ago
|
||
Backed out because of bug 834432: https://hg.mozilla.org/mozilla-central/rev/169e0492b03b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•11 years ago
|
||
This combines the now backed out patch from this bug and the patch from bug 834432.
Attachment #706142 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #705510 -
Attachment is obsolete: true
Comment 7•11 years ago
|
||
Comment on attachment 706142 [details] [diff] [review] Correctly handle non chrome directories when doing l10n-repack Review of attachment 706142 [details] [diff] [review]: ----------------------------------------------------------------- I lied about 4 hours. I remember looking at most of this last night. Not sure why I didn't hit r+ then. Would be really nice to have test coverage of l10n repacks. These break way too often...
Attachment #706142 -
Flags: review?(gps) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Thanks for the review. I agree we need test coverage for these. But let's already try to fix them :) https://hg.mozilla.org/mozilla-central/rev/52c92a6c6e24
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•