833948 - mozRTCIceCandidate constructor looks for 'sdbMid' rather than 'sdpMid' in its argument

Status: VERIFIED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Andrew Miller]

Attachment: Test case which creates a RTCIceCandidate and fetches the sdpMid property.

According to http://www.w3.org/TR/webrtc/#idl-def-RTCIceCandidate, the RTCIceCandidate constructor expects a property called 'sdpMid'. However, the code (in dom/media/PeerConnection.js IceCandidate.prototype.constructor) typos that as sdbMid.

Test case attached:
  Expected results with testcase: "y" shows up in the alert.
  Actual result with testcase: "z" shows up in the alert.

Comment 1

[Andrew Miller]

Attachment: Simple patch to fix the misspelling - no attempt at bug compatibility

Comment 2

[Andrew Miller]

I don't have try-server access or access to all the platforms, so have only tested this on Linux x86-64 so this may need to be tested on the try server first.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6eea9913acdd

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6eea9913acdd

Comment 5

[Jason Smith [:jsmith]]

Verified on 1/30 build. Probably worth getting a quick error test here.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a fix of a spelling error in the code. I can't imagine there is something we could test here.