833949 - convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

Defined as a variable in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 738 -- m_cachedMemCacheEntries->AppendElement(cacheEntrySupports);
        line 750 -- m_cachedMemCacheEntries->RemoveElement(cacheEntrySupports); 
    mailnews/base/util/nsMsgMailNewsUrl.h (View Hg log or Hg annotations)
        line 60 -- nsCOMPtr<nsISupportsArray> m_cachedMemCacheEntries; 

Referenced in:

    mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
        line 732 -- if (!m_cachedMemCacheEntries)
        line 733 -- NS_NewISupportsArray(getter_AddRefs(m_cachedMemCacheEntries));
        line 734 -- if (m_cachedMemCacheEntries)
        line 746 -- if (m_cachedMemCacheEntries)

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 705536 [details] [diff] [review]
patch

It's OK but I'd have preferred an nsCOMArray.

Comment 3

[:aceman]

Why? Isn't nsTArray more strict?

Comment 4

[:aceman]

Attachment: patch v2

Comment 5

[[e-mail]]

Comment on attachment 706527 [details] [diff] [review]
patch v2

nsCOMArray can do things that nsTArray can't and uses less code. However it does have a weird API, and I'm still waiting on review to fix that :-(

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/cb616b4ba9b4