833982 - Trying to make a call when no voice network is available silently fails with no feedback to user

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Get phone into a state where there's no connected voice network (e.g., bug 833979)
 (2) Open dialer app
 (3) Try to make voice call

The call obviously fails, but there's no feedback at all.

In logcat I see

[JavaScript Error: "TypeError: conn.voice.network is null" {file: "app://communications.gaiamobile.org/dialer/js/oncall.js" line: 179}]

so maybe we're trying to show feedback but the code has regressed.

bb? -> radar, but there may be some regulatory issues here.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: WIP

3 issues:
- we display the callscreen even when there is a call error (new one)
- we're not handling properly the case where conn.voice is null
- the RIL error is probably not 'recognized' by the handleError code in telephony_helper.js (we don't display the error dialog if we don't have a wording apparently)

This patch fixes 1 and 2.

For #3 we could either handle this precise error or add a "generic error" message, any case it's a late-l10n.

Comment 2

[Etienne Segonzac (:etienne)]

Daniel, do you know what we should do?

Comment 3

[Daniel Coloma:dcoloma]

When we developed this feature (seems this regressed) we used the following Acceptance Criteria:

"When a user tries to make a phone call from any of these entry points:

A/ The dialpad by entering manually the phone number and clicking the "dial button" afterwards
B/ The call log by selecting an entry in the log
C/ The address book by tapping on a phone number linked to a contact

Instead of placing the phone call, the user is notified via a confirmation dialogue which Title "No Network connection", message "In order to make a call, you must first have a network connection" and an "OK" button.

When the user clicks "OK", he is returned to:

A) The dialpad with the number to be called shown in the dialpad.
B) THe Call Log
C) The Contact Detail

If the phone number entered (either by A, B or C) entry points is an Emergency Number, the call should be placed and no error should be returned to the user"

in case #3, as per your comment 1. Are you referring to an unexpected RIL error when making the call?

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Daniel Coloma:dcoloma from comment #3)
> in case #3, as per your comment 1. Are you referring to an unexpected RIL
> error when making the call?

We present the "To make a call, the phone must be connected to a network." message for the BadNumberError error.
I don't know what's the error here (don't have a T-mobile sim card handy) but it's not this one.

Removing the late-l10n here since we're probably going to display the same message, just need to know which error we get.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The error state I was seeing was "searching for network" (which is a lie, bug 833979).

Comment 6

[Etienne Segonzac (:etienne)]

Sorry for the imprecision, I need to know the string we get here: 

https://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/telephony_helper.js#67

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Sorry, I can't reliably reproduce the network bustage :(.  Hsin-Yi has been seeing this too; she might be able to reproduce the problem more reliably than I can.

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

With this patch:

- we're closing the callscreen when the dialed call gets an error
- we prevent the nasty JS error
- if there is no voice network we don't event try to place the call and display an error directly

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 706031 [details] [diff] [review]
Patch proposal

Review of attachment 706031 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looking good, tried on the phone with normal usage and works fine, with airplane mode and so on, but couldn't reproduce the scenario when no conn.voice.network
Looking good to me, r+

Great job Etienne.

::: apps/communications/dialer/js/oncall.js
@@ +175,4 @@
>  
>    // Setting up the SimplePhoneMatcher
>    var conn = window.navigator.mozMobileConnection;
> +  if (conn && conn.voice.network) {

We could check for voice === null, just in case ;P

if (conn && conn.voice && conn.voice.network)

::: apps/communications/dialer/js/recents.js
@@ +230,4 @@
>  
>      // Setting up the SimplePhoneMatcher
>      var conn = window.navigator.mozMobileConnection;
> +    if (conn && conn.voice.network) {

Same here

Comment 10

[Etienne Segonzac (:etienne)]

Attachment: Patch v2

Patch with comments addressed.
Lucky me, I had the issue on my otoro this morning (not picking up signal), and it works perfectly :)

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 706290 [details] [diff] [review]
Patch v2

Nice, thanks Etienne!

Comment 12

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/5df0c698b0c3f386b02e670a15e100a5d59ec3cd

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Ryan, I am curious why you set the status-b2g18* flags to 'fixed' when this bug was never uplifted to v1-train or v1.0.0.  Please make sure that the bug is landed on branches before marking as fixed.  This caused a lot of confusion for us this morning, resulting in bug 838761.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Sorry about that, must have gotten caught up in the mess when I was making mass changes to some other bugs :(

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Thanks Francisco.

v1-train: ea0ca1f2fa169247ec6c1fa0dae735904a8aabe7
v1.0.0: 8171b24e52318788a19d05a62854ec6e6ca1219f