834048 - Deleting files from the download manager does not remove the files from the device

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Bill Gianopoulos [:WG9s]]

Using currently Nightly and Aurora builds, deleting files via the download manager just removes the download manager entry, but fails to actually delete the file.

This forks fine on the current Beta version.

Comment 1

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos [:WG9s] from comment #0)
> Using currently Nightly and Aurora builds, deleting files via the download
> manager just removes the download manager entry, but fails to actually
> delete the file.
> 
> This forks fine on the current Beta version.
       ^^^^^
       works

Comment 2

[Bill Gianopoulos [:WG9s]]

The regression window is:

http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=331b0a480586&tochange=91d5f962e553

Bug 820491?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's try to figure this out and get an uplift ready.

Comment 4

[Wesley Johnston (:wesj)]

There's a scoping  error with the logging that I saw yesterday (this.log is not defined) in removeDownload, but that will likely just show us whats being logged...

Comment 5

[Brian Nicholson (:bnicholson)]

From logcat (with bug 834400 fixed):

01-24 12:16:28.161 26435 26527 E GeckoConsole: Error: removeDownload() [Exception... "Not enough arguments [nsIFile.remove]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://browser/content/aboutDownloads.js :: dl_removeDownload/< :: line 457"  data: no]

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Add required param for f.remove()

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f07f88fd036a

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 706014 [details] [diff] [review]
Add required param for f.remove()

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 820491
User impact if declined: files on phone aren't deleted when removed from download manager
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f07f88fd036a

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 706014 [details] [diff] [review]
Add required param for f.remove()

looks good, regression fix with low risk - approving.

Comment 11

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aeb0bb88687f

Comment 12

[Paul Feher]

Verified fixed on Samsung Galaxy SII  (Android 4.0.3)/ Nightly 21.0a1(2013-01-28) /Aurora 20.0a2(2013-01-28)

Comment 13

[Ioana Chiorean]

There is already a TC in Moztrap for this: https://moztrap.mozilla.org/manage/case/831/

Should we adjust more this one? or it is OK with you too?