834290 - Add support for iPads and iPhones in useragent strings

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[David Weir (satdav)]

So aware it thinks the iphones running IOS 6 is mac x 

for when trying to guess what os you are running

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 782852 [details] [diff] [review]
patch, v1

Review of attachment 782852 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 3

[Simon Green]

Given that neither iOS or separate versions are not in Bugzilla::DB's ENUM_DEFAULTS, should this patch really go upstream or is it better suited to BMO?

Comment 4

[Frédéric Buclin]

(In reply to Simon Green from comment #3)
> Given that neither iOS or separate versions are not in Bugzilla::DB's
> ENUM_DEFAULTS, should this patch really go upstream or is it better suited
> to BMO?

Upstream. We decided some years ago to implement the logic to get the correct platform and OS, and let admins add the ones relevant to their installation.

Comment 5

[Simon Green]

(In reply to Frédéric Buclin from comment #4)
> Upstream. We decided some years ago to implement the logic to get the
> correct platform and OS, and let admins add the ones relevant to their
> installation.

Thanks for the clarification.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/UserAgent.pm
Committed revision 8681.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/UserAgent.pm
Committed revision 8587.

Comment 7

[David Weir (satdav)]

Hi matt do you know the user ident for the touch

Comment 8

[Matthew N. [:MattN]]

Wrong bug it seems. In bug 905537 comment 0 I explained that the regex's need to look for "iPod" as well as the two others.