834689 - Work - Add multi-selection to richgrid as stop-gap

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Cross-slide and multiple-selection are slated for the new proposed tilegroup widget. In order to unblock the implementation of the contextual appbar and the views & tiles actions that depend on it, we need a stop-gap measure that adapts the existing richgrid with enough to test and work through contextual-action flows

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Implements multiple selection behavior on richgrid/richgriditem, triggerd via contextmenu (stop-gap)

This is just the richgrid/richgrid item changes which allow us to fire a selectionchange event on the grid and the user to toggle tile selection (via contextmenu/right-click/long-press until cross-slide is implemented). 

I'm still fighting getting tests to run in the xul file so I'll land that seperately if/when its ready.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Implements multiple selection behavior on richgrid/richgriditem, triggerd via contextmenu (stop-gap)

Addressed feedback to use selectedItems property instead of QSA in clearSelection. 
I left the selectionchange event behavior as-is, rather than calling some method on the controller. This seems more like the expected, DOM-ish behavior and we can stop events bubbling to avoid them being global if it becomes a perf. problem.

Comment 3

[Sam Foster [:sfoster] (he/him)]

https://hg.mozilla.org/projects/elm/rev/1d467cd2359b