834819 - Video (ImageLayers?) not rotated correctly with hwc

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Screenshot

STR
 (1) Launch video app in portrait orientation
 (2) Load any video, let it play for a moment
 (3) Switch to landscape orientation

The image isn't rotated, it's instead scale-transformed out to the rotated bounds.

Comment 1

[Diego Wilson [:diego]]

Forgot to look at the world transform rotation :S The patch is simple. I'll share it ASAP

Comment 2

[Diego Wilson [:diego]]

Attachment: Make HwcComposer2D honors world transform

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 706697 [details] [diff] [review]
Make HwcComposer2D honors world transform

>diff --git a/widget/gonk/HwcComposer2D.cpp b/widget/gonk/HwcComposer2D.cpp

>+        //we find a fuzzy zero the same way as
>+        //PreservesAxisAlignedRectangles()

Nit: style would be

          // Compute fuzzy equal like PreservesAxisAlignedRectangles()

r=me with that.

Comment 4

[Diego Wilson [:diego]]

Attachment: Make HwcComposer2D honors world transform v2

Addressed nit from previous patch

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 706812 [details] [diff] [review]
Make HwcComposer2D honors world transform v2

(Code review point of order: if I say, "r=me with the above comments addressed", then I don't need to see the next patch that addresses the comments; you can take r+.  Especially for things like indentation or style changes.  But, always feel free to re-request review if you'd like.)

Comment 6

[Diego Wilson [:diego]]

cjones,

I see. You've been kind enough to help me land all of these patches. What's does one usually do to get the it landed after it's been r+'ed?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Best is to set checkin-needed and wait for someone to snarf it.  Or if you need to escalate to someone with push access, like m1 ;).

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also, we should get you push access :).  Please file a bug on L1 [1]

[1] http://www.mozilla.org/hacking/committer/

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a31b07df79df

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This blocks enabling hwc, which is needed for shippable power-usage numbers.  This will either make into v1.0.0 through official gecko upstream or as a downstream patch to it.  Let's make everyone's lives easier and land upstream.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Please update status-b2g18 and status-b2g18-v1.0.0 to fixed once this has been uplifted to mozilla-b2g18 and mozilla-b2g18_v1_0_0 branches.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5431cb750db1
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/ac5a6c368313

Comment 13

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on Ubuntu 13.04 x86 on FF 21RC4.