835002 - Add back Growl support for TB19/20/21 and SM 2.16/2.17/2.18

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Philip Chee]

We should add back GROWL support to TB19/20 and SM 2.16/2.17 since Firefox is doing it in Bug 827979.

+++ This bug was initially created as a clone of Bug #806254 +++
> If Bug 805837 adds back Growl support to Gecko 18, we should also reverse
> the changes we have done in Bug 792793 for comm-aurora.

Bug 827979 - add Growl support back for Firefox 19 (Beta) and Firefox 20 (Aurora)

From Bug 827979 Comment 0:

> My understanding is that XUL notifications will come from bug 782211 but
> that has still not been completed. I think we should add growl back to 19
> and 20 for the same reason as we did for 18.

Comment 1

[Nomis101]

Attachment: Patch for TB19 / SM2.16

Comment 2

[Nomis101]

Attachment: Patch for TB20 / SM2.17

Comment 3

[Nomis101]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 827979
User impact if declined: No notification support at all on OS X 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): No risk, same patch as in Bug 806254

Comment 4

[Nomis101]

Comment on attachment 706829 [details] [diff] [review]
Patch for TB20 / SM2.17

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 827979
User impact if declined: No notification support at all on OS X 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): No risk, same patch as in Bug 806254

Comment 5

[Nomis101]

By the way, both patches are the same and the same as the patch for Bug 806254. But made from different branches.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

wrong flags, resetting.

Comment 7

[Rich Gray (:rbgray)]

Yay!  WFM now.  Hadn't realized how much I'd miss Growl.   Thanks!

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:19.0) Gecko/20100101 Firefox/19.0 SeaMonkey/2.16
    Build identifier: 20130130211905

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

If the SM team want to take this or not, that's up to them. We're not going to be releasing another beta of TB in this cycle.

Comment 9

[Mark Banner (:standard8)]

Bumping versions in title, since bug 827979 also landed growl support back on mozilla-central.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 706829 [details] [diff] [review]
Patch for TB20 / SM2.17

Looks good to me.

Comment 11

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/48831ce7db7d

Comment 12

[Ian Neal]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

Probably worth asking stefanh for feedback too.

Comment 13

[Mark Banner (:standard8)]

(In reply to Ian Neal from comment #12)
> Comment on attachment 706828 [details] [diff] [review]
> Patch for TB19 / SM2.16
> 
> Probably worth asking stefanh for feedback too.

I was more thinking of the late l10n string perspective than the viability of the patch.

Comment 14

[Stefan [:stefanh]]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

f+ for attachment #706829 [details] [diff] [review] too since it's the same patch ;-)

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 706829 [details] [diff] [review]
Patch for TB20 / SM2.17

https://hg.mozilla.org/releases/comm-aurora/rev/3c479c9f8c57

Comment 16

[Justin Wood (:Callek)]

Comment on attachment 706828 [details] [diff] [review]
Patch for TB19 / SM2.16

r+ and a+ (though it is late) its had plenty of bake, I can't set a+ though in this component. :(

Comment 17

[Justin Wood (:Callek)]

Mark, can you rubber-stamp this for me (I know it has late-l10n, but I think its worth it given the growl re-add, for SeaMonkey) -- for TB theres no more betas anyway.  I want this landed by the time the migrations start.

Comment 18

[Philip Chee]

Pushed to comm-beta r+a=Callek:
http://hg.mozilla.org/releases/comm-beta/rev/c32f17244f9a