835007 - Should allow "all" in transition-property even if it's not the only value

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The spec at http://dev.w3.org/csswg/css3-transitions/#transition-property says that "transition-property: all, margin-top" is valid as far as I can tell.  But CSSParserImpl::ParseTransitionProperty doesn't allow that, and neither does CSSParserImpl::ParseTransition.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note http://stackoverflow.com/questions/14533519/how-can-i-specify-a-css3-transition-to-all-properties-but-with-one-exception-ov for an example of how people want to use this.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, this was a change in the spec; I had a note in my todo list to deal with it, but hadn't filed a bug yet.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have a patch in my patch queue; still needs tests.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Make 'transition-property: all' work as an item within a list.

TODO: needs tests

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712092 [details] [diff] [review]
Make 'transition-property: all' work as an item within a list.

Hmm.  We don't need transition manager changes to handle this?

r=me on the parts that are here; might be good explaining in the checkin comment why the transition manager doesn't need changing.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee270530f069

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee270530f069

Comment 9

[David Vest]

FYI, there's a comment in CSSParserImpl::ParseTransition() that hasn't been updated.

  //   + If there is more than one item, then none of the items can be
  //     'none' or 'all'.

'or 'all'' should probably be removed at some point. It did fool me to believe for a while that Firefox hadn't updated to the new behavior.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Thanks for pointing that out; I've stuck a patch to fix it in my queue, which I'll commit the next time I'm landing stuff.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment adjusted in https://hg.mozilla.org/integration/mozilla-inbound/rev/695c35eb1b8b

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/695c35eb1b8b