835261 - [ko] Add Korean keyboard in Gaia on Firefox OS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Channy Yun [:channy]]

We have to add Korean keyboard to Gaia user interface.
https://github.com/mozilla-b2g/gaia/tree/master/apps/keyboard/js

Comment 1

[Channy Yun [:channy]]

I surveyed some of Korean IMEs based on Javascript.
1. http://ohi.kr/ and http://ohi.kr/ohi.js (GPL)
2. http://colspan.net/hangulime/ (MIT)
3. https://gist.github.com/wkpark/5310769 (New BSD)

Mr. Wonkyu Park developed #3 Saenaru IMEs and it's very good for me. 
If you can port it to Firefox OS, it'll be very nice works!

Comment 2

[Channy Yun [:channy]]

For new team,

Check out the status of Gaia keyboard.
https://wiki.mozilla.org/Gaia/System/Keyboard/Layout#Known_implementations 
Develop together in https://github.com/mozillakr/gaia

Comment 3

[Channy Yun [:channy]]

We want to consider adding "Hanson IME" by Son, Sangkil

Demo: http://www.zannavi.com/hanson/
Code: http://www.zannavi.com/work/hanson.tar.gz
License: GPL

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

If you would like to contribute to Gaia and have the IME added to the open source codebase, please make sure the open source license is comparable to Apache License.

https://github.com/mozilla-b2g/gaia/blob/master/LICENCE

So no GPL nor LGPL, AFAIK :-/

Comment 5

[BYUN Sangpil]

Attachment: link to the pull request

Review Please.

Comment 6

[Channy Yun [:channy]]

Comment on attachment 818317 [details] [review]
link to the pull request

Sangphil, review flag is not for you. :)

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 818317 [details] [review]
link to the pull request

Thanks for the contribution!

As this is a simple Hangul keyboard layout with IME (no Hanja) I don't see major issue to check-in this first.

Rudy, :djf, could you check double check to see if this works for everyone?

Comment 8

[Channy Yun [:channy]]

Only typing Korean is the most of use cases in modern smart phone life in Korea except Hanja. :)

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Hi Sangpil,

I am sorry that this bug does not land in time. However because of bug 884752 you would need to rebase your patch.

I've updated the documentation for you on that.
https://wiki.mozilla.org/Gaia/System/Keyboard/Layout

Comment 10

[BYUN Sangpil]

Hi Tim.

It's ok. And Thank you for the documentation.

I rebased my patch onto mozilla-b2g/master branch.
Please review again.

Thank you.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 818317 [details] [review]
link to the pull request

Looks good!

The |keyboardGroups| part is dead code and due to be removed though.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/987e1035d32ded28c830ad5867e38d6ee15e107a

Thank you!

Comment 13

[BYUN Sangpil]

Thank you Tim.

Awesome!! Today is special day for me.
Thank you for helping that first contribution.

Comment 14

[Channy Yun [:channy]]

How to enable Korean keyboard for testing in firefox 1.3 nightly? I updated recent nightly version in geeksphone, but there is no Korean keyboard.

Comment 15

[Jan Jongboom [:janjongboom] (inactive)]

Hi Channy, you'll have to make gaia with the keyboard env variable set to include Korean.

|GAIA_KEYBOARD_LAYOUTS?=en,ko make|

Or post this on the GeeksPhone forums as they're very reluctant to add new languages to their builds.

Comment 16

[Geeksphone]

Done

Comment 17

[Channy Yun [:channy]]

(In reply to Geeksphone from comment #16)
> Done

(In reply to Jan Jongboom [:janjongboom] from comment #15)
> Hi Channy, you'll have to make gaia with the keyboard env variable set to
> include Korean.
> 
> |GAIA_KEYBOARD_LAYOUTS?=en,ko make|
> 
> Or post this on the GeeksPhone forums as they're very reluctant to add new
> languages to their builds.

Thanks for Jan and Geeksphone!
http://forum.geeksphone.com/index.php?topic=5792.0

Comment 18

[Channy Yun [:channy]]

(In reply to Geeksphone from comment #16)
> Done

Hi, Geeksphone.

I asked to add ko to the latest build on forum to test Korean keyboard.
Would you check again?

Comment 19

[Channy Yun [:channy]]

I reopened for some reasons. Not yet fixed some of issues on v1.3 keyboard layout change Bug 994495 and not to ship Korean keyboard in default on Keon reference phone.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am closing this bug because we generally don't REOPEN bug without reverting the patch.

If you want to track the progress of Keon on Bugzilla@Mozilla, file a bug under Firefox OS::Vencomm and mark [POVB] (Part of vendor build) on the whiteboard.

Thanks!