835484 - Localized "complete" and "failed" strings are not used in BT file transfer notification status

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Théo Chevalier]

When a Bluetooth file transfer finished, the notification displayed at the top of the screen (the string is bluetooth-file-transfer-result in system.properties) is localized, but not the {{status}} variable in it.
Verified in French when the status is "complete".

I got "complete du transfert de fichier par Bluetooth."
Instead of "Réussite du transfert de fichier par Bluetooth."

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Does this happen with leo shipping languages too or just in French (which we believe is not a v1.1 shipped locale)?

Comment 2

[Alex Keybl [:akeybl]]

(In reply to [e-mail] from comment #1)
> Does this happen with leo shipping languages too or just in French (which we
> believe is not a v1.1 shipped locale)?

For clarification, this would be blocking-b2g- if it only affected French (French isn't a v1.0.1/v1.1 locale)

Comment 3

[Théo Chevalier]

Delphine, I will try again with another locale once I receive the phone (maybe it is fixed since I opened the bug). But feel free to verify first if it take too much time.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Investigating at the moment:
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/system/locales/system.fr.properties#L192

Spanish should show it at the end : 
https://hg.mozilla.org/gaia-l10n/es/file/0fc4d28a3269/apps/system/system.properties#l216

as well as pt_BR:
https://hg.mozilla.org/gaia-l10n/pt-BR/file/55c0026a906a/apps/system/system.properties#l214

Looks like they are all using {{status}} which should be translated for complete and failed in the following 2 lines.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Spanish should be "completada" not "complete".

I believe this affects all languages.  There are other things notifications that are not getting translated as well for bluetooth.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: notification screenshot not translated

https://hg.mozilla.org/gaia-l10n/es/file/0fc4d28a3269/apps/system/system.properties#l199  

shows that it should be translated.  [Side note: t is missing in the spanish translation.  See the line.]

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[side note : Filed bug 855755 for the missing t.]

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Forgot to list what I was testing on:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/879324d41588
Gaia   e7e7c1a473b4069544f2dad779b1c9b1bab91663
BuildID 20130327070202
Version 18.0
Unagi

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c516d7e67150
Gaia   d40dcdd112f12e2a5a0d1de46451670918fd4369
BuildID 20130328070202
Version 18.0

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: leo+ as the word seem to have missed to be translated in multiple languages

Comment 10

[Axel Hecht [:Pike]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/bluetooth_transfer.js#L361 is the code in question, that doesn't _() the status itself.

Given that the strings exist, they'd only be exposed newly. I don't think we're loosing any testing knowledge by exposing them now.

Thus no late-l10n, but it is l12y.

Technically, we could take a patch for 1.0.1, too, IMHO. Just saying.

Comment 11

[Fabien Cazenave [:kaze]]

Ian-Liu, please let me review this one. :-)

Comment 12

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8956

Pointer to Github pull-request

Comment 13

[[e-mail], [e-mail]]

Comment on attachment 732677 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8956

Add localized method for the status string.

Kaze,
Thanks for reviewing my pr.

Comment 14

[Fabien Cazenave [:kaze]]

Comment on attachment 732677 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8956

lgtm, merged on master:
https://github.com/mozilla-b2g/gaia/commit/899af387a9be0f94f9f68b0c51714ca3de518225

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 899af387a9be0f94f9f68b0c51714ca3de518225 as:
v1-train: 0a44b3de3d9c550f5bb520d04721fc8120eabc2d

Comment 16

[Staś Małolepszy :stas]

Can we take this on 1.0.1 as well?

Comment 17

[[e-mail], [e-mail]]

Not a blocking issue, but cannot localize well.
Nominating tef+..

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 6b4e3334ae59b0bee461721022bf6e5a8ce69441

Comment 22

[Carlos Martínez Toral [:carlosmartinez]]

Verified fixed on inari device with:

Gaia   34ceae4e9b32231461804d37fb5f1c49f54fcf86
BuildID 20130417003914
Version 18.0

from v1.0.1 branch