835688 - buildstep that TinderboxPrints the mozharness_revlink makes tbpl ugly and stupid-looking

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect, P1)

Description

[Phil Ringnalda (:philor)]

Back in September in bug 791029, tbpl stopped insisting that only TinderboxPrints which are at the start of a line count as TinderboxPrints.

That made TinderboxPrint something like Beetlejuice, not a word you want to casually toss around.

The buildstep in b2g builds which outputs the mozharness_revlink doesn't fear saying it:

========= Started 'echo TinderboxPrint: ...' (results: 0, elapsed: 0 secs) (at 2013-01-28 20:31:27.515588) =========
echo TinderboxPrint: mozharness_revlink http://hg.mozilla.org/build/mozharness/rev/f7ba3a5cffee
...
 argv: ['echo', 'TinderboxPrint:', 'mozharness_revlink', 'http://hg.mozilla.org/build/mozharness/rev/f7ba3a5cffee']
...
TinderboxPrint: mozharness_revlink http://hg.mozilla.org/build/mozharness/rev/f7ba3a5cffee
...
========= Finished 'echo TinderboxPrint: ...' (results: 0, elapsed: 0 secs) (at 2013-01-28 20:31:27.623114) =========

Which results in b2g builds having six line items in the unordered list in the bottom right: the gaia_revlink which we only get because of bug 791029, since it's a mozharness style one with a time and an INFO in front of it, and five lines of the mozharness_revlink in varying degrees of readability, including "...' (results: 0, elapsed: 0 secs) (at 2013-01-28 20:31: 27.515588) ========="

Comment 1

[Justin Wood (:Callek)]

Regression From Bug 829145

Comment 2

[Justin Wood (:Callek)]

So as an ugly workaround in buildbot you can do something like:

$ python -c "print 'Tinder' 'Box' 'Print:'"

instead of 'echo' for this, python auto-concats all adjacent strings together.

and you might get around the ========= Finished 'echo TinderboxPrint: ...'   stuff by just adding a description= to the step. (that doesn't use the TinderboxPrint phrase).

Comment 3

[Aki Sasaki (not active)]

Looks like the other TinderboxPrint steps are OutputStep's:
http://hg.mozilla.org/build/buildbotcustom/file/ce06f2f829ff/process/factory.py#l1386
http://hg.mozilla.org/build/buildbotcustom/file/ce06f2f829ff/process/factory.py#l3298

Comment 4

[Armen [:armenzg]]

Attachment: Use OutputStep instead

Comment 5

[Armen [:armenzg]]

Comment on attachment 707636 [details] [diff] [review]
Use OutputStep instead

0f3e640208d0

Comment 6

[Aki Sasaki (not active)]

This is in production.

Comment 7

[Armen [:armenzg]]

It looks like this now:
* mozharness_revlink: http: //hg.mozilla.org/build/mozharness/rev/ce8901b71fed
* gaia_revlink: http: //hg.mozilla.org/integration/gaia-nightly/rev/ff42ce81a69c

I have not yet understood why tbpl add that space after "http:".