835988 - Strings on Cost Control main screen tabs and buttons need updating

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[marcoc]

Strings on tabs of main screen and Top-Up buttons need updating to be consistent with language in rest of app, and to clarify to user what to expect when button is pressed.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Can we have some wireframes? We don't have any Vivo SIM to test the top-up and (mostly) everything else.

Thanks!

Comment 2

[Salvador de la Puente González [:salva]]

Hello Marco, can you clarify what kind of updating? What are you referring to?

Comment 3

[marcoc]

(In reply to Salvador de la Puente González [:salva] from comment #2)
> Hello Marco, can you clarify what kind of updating? What are you referring
> to?

Salva and Guillermo:
Please refer to this document for updated copy in the application. 

https://www.dropbox.com/s/elbek9lye7dj639/OWD%20Data%20Usage%20V15%2020130212%20updated.pdf

Take note of copy in: 
- the tabs in prepaid and postpaid scenario
- the top-up buttons
- the top-up and balance update error messages
- the prompts and notifications
- the settings area line items and prompts

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Is this for v1-train?

Comment 5

[Salvador de la Puente González [:salva]]

Attachment: Strings of Usage application updated

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 719873 [details]
Strings of Usage application updated

Grabbing stas' review request, and turning that into the feedback+.

There's a bunch of detail here, I'd like Francisco to go into that.

I don't understand the costcontrol app good enough to be sure about all strings, in particular I don't know how to reproduce the "below" options.

Generally, this looks good, though. Some strings made my eyebrows rise, but were making strings in the html consistent with the .properties only. The other was upper-casing the Usage app name. those are cool.

Also, thanks for getting rid of the CSS upper/lower/etc casing rules, that's good.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 719873 [details]
Strings of Usage application updated

Simple change, looking good :)

Comment 8

[Salvador de la Puente González [:salva]]

Master: 9fdf0d138eb0d9f4a2fde56ad9f7e57d4da074f1

Comment 9

[Salvador de la Puente González [:salva]]

Comment on attachment 719873 [details]
Strings of Usage application updated

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: Interface / errors strings

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Axel Hecht [:Pike] from comment #6)
> Comment on attachment 719873 [details]
> Strings of Usage application updated

Axel - should we be changing these l10n-ids before uplift? Not sure how our l10n branching is working right now, so I want to verify.

Comment 11

[Axel Hecht [:Pike]]

See my comment 6. Francisco, did you check if all strings that actually changed got their ID changed, and those that didn't change didn't?

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Hi :Pike,

I've been going in deep through all the strings and discovered two of them that we will need to modify, in fact we created the new ids but didn't used them:

topup-ussd-button (old one, we created topup-ussd-button2, but didn't used in the dom)
topup-button (old one, we created topup-button, but didn't used in the dom).

I've already told Salva about this, and we have just one question, do you want us to backout the commit and amend it or do you prefer a follow up?

Cheers!
F.

Comment 13

[Axel Hecht [:Pike]]

Whichever is more reliable for the uplift to v1-train, I guess.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage Comment: Waiting for either backout or forward fix from comment 12 before approving this for uplift.

Comment 15

[Salvador de la Puente González [:salva]]

Attachment: everting 9fdf0d138eb0d9f4a2fde56ad9f7e57d4da074f1

Please note telephony.css changed after so it is a merge. I restored CSS transformations but they will be stripped out once the fixed PR is ready.

Comment 16

[Salvador de la Puente González [:salva]]

Talking with Francisco, no review needed for the revert. Just applying and asking for the new one.

Comment 17

[Salvador de la Puente González [:salva]]

Attachment: String update

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 723996 [details]
String update

Done, all strings re-re-re-reviewed ;)

Comment 19

[Salvador de la Puente González [:salva]]

Stas, can you give me feedback about this patch.

Comment 20

[Salvador de la Puente González [:salva]]

Axels, can we land this bug? I was waiting for Stas feedback but as you change my review? by a feedback+ in comment 6 I have though if you could grant me the feedback+ instead.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 723996 [details]
String update

Looks good to me.

Comment 22

[Salvador de la Puente González [:salva]]

Master: be0a07f1de0681ec72e23f91ff0862f7bddc53a0

Comment 23

[Salvador de la Puente González [:salva]]

Removing uplift due to all is well reviewed. I don't know if necessary but asking for approval again.

Comment 24

[Salvador de la Puente González [:salva]]

Comment on attachment 723996 [details]
String update

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: refer to https://github.com/mozilla-b2g/gaia/pull/8599

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 be0a07f1de0681ec72e23f91ff0862f7bddc53a0
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 26

[Salvador de la Puente González [:salva]]

Merge conflict. telephony.css was improperly merged in bug 835928. Here is fixed.
v1-train: 3ca820b181bf66072732fe4ca998035294a4f13e