Closed
Bug 836124
Opened 11 years ago
Closed 11 years ago
Replace imgIContainer::GetCurrentFrameIsOpaque() with [noscript] FrameIsOpaque(aWhichFrame)
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: seth, Assigned: seth)
Details
Attachments
(1 file, 2 obsolete files)
The |currentFrameIsOpaque| attribute on imgIContainer is not used by any addons in the addons MXR, nor by any JavaScript code of ours. It should be marked |noscript|. Furthermore, it is preferable that all methods which operate on the current frame should be replaced with versions which take an |aWhichFrame| argument, as this makes it much easier to ignore animation on particular instances of images. So the overall proposed change here is to go from this: > readonly attribute boolean currentFrameIsOpaque; To this: > [noscript] boolean frameIsOpaque(in uint32_t aWhichFrame);
Assignee | ||
Updated•11 years ago
|
Summary: Replace imgIContainer::GetCurrentFrameIsOpaque() with [noscript] GetFrameIsOpaque(aWhichFrame) → Replace imgIContainer::GetCurrentFrameIsOpaque() with [noscript] FrameIsOpaque(aWhichFrame)
Assignee | ||
Comment 1•11 years ago
|
||
Proposed patch. Try job here: https://tbpl.mozilla.org/?tree=Try&rev=1dcc12493d9d
Attachment #707917 -
Flags: review?(joe)
Assignee | ||
Comment 2•11 years ago
|
||
Whoops! Forgot to change the imgIContainer UUID. No need for a new try run.
Attachment #707923 -
Flags: review?(joe)
Assignee | ||
Updated•11 years ago
|
Attachment #707917 -
Attachment is obsolete: true
Attachment #707917 -
Flags: review?(joe)
Comment 3•11 years ago
|
||
Comment on attachment 707923 [details] [diff] [review] Replace GetCurrentFrameIsOpaque() with [noscript] FrameIsOpaque(aWhichFrame). Review of attachment 707923 [details] [diff] [review]: ----------------------------------------------------------------- ::: image/public/imgIContainer.idl @@ +151,5 @@ > + * behind it. > + * > + * @param aWhichFrame Frame specifier of the FRAME_* variety. > + */ > + [noscript] boolean frameIsOpaque(in uint32_t aWhichFrame); If you make this notxpcom too, it'll have a boolean return value instead of nsresult. Up to you.
Attachment #707923 -
Flags: review?(joe) → review+
Assignee | ||
Comment 4•11 years ago
|
||
I'm fine with that. The only thing we lose is the ability to signal the caller that they passed an invalid FRAME_* enumeration value in, which doesn't seem that important because any code that does that is just wrong. I'll make that print an NS_WARNING instead. Thanks for the review!
Assignee | ||
Comment 5•11 years ago
|
||
Switched from [noscript] to [notxpcom]. Should be OK without another try run.
Assignee | ||
Updated•11 years ago
|
Attachment #707923 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
This should be good to go. Requesting checkin.
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04be5f5f4b18
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04be5f5f4b18
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•