836196 - nricemediastream.h:136:13: warning: private field 'components_' is not used [-Wunused-private-field] (and similar in nricectx.h)

Status: RESOLVED DUPLICATE of bug 825105

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning on Mac OS X:
{
In file included from nricemediastream.cpp:69:
../../../../media/mtransport/nricemediastream.h:136:13: warning: private field 'components_' is not used [-Wunused-private-field]
  const int components_;
            ^
1 warning generated.
In file included from nricectx.cpp:82:
../../../../media/mtransport/nricectx.h:231:8: warning: private field 'offerer_' is not used [-Wunused-private-field]
  bool offerer_;
       ^
1 warning generated.
}

Comment 1

[Daniel Holbert [:dholbert]]

Sample log w/ these warnings: https://tbpl.mozilla.org/php/getParsedLog.php?id=19265538&tree=Try

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

In both cases, the parameter in question is used elsewhere in the ::Create() method, but the version of it that's stored as member-data is never used, so that one can be dropped.

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 708004 [details] [diff] [review]
fix

Review of attachment 708004 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer to keep these fields around. They're useful for debugging and may some day appear in log messages.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix v2

OK -- given that, we probably want to just silence the warning messages by 'using' these variables w/ unused<<.

Also, as an optimization: we can presumably mark these as DebugOnly, since they don't do us any good in opt builds. (and there's no use allocating space for them at in opt builds if they're only there for debugging purposes)

(You mentioned that we might want to include these in logging someday -- if we do that in opt builds, then we could remove DebugOnly at that point; but for now, we don't need these variables in opt builds)

Comment 5

[Daniel Holbert [:dholbert]]

Looks like bug 825105 just silenced these warnings w/ (void) casts. Duping to that bug, and canceling review request.