Closed
Bug 83634
Opened 23 years ago
Closed 23 years ago
Can't get messages from POP server
Categories
(MailNews Core :: Networking: POP, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: kazhik, Assigned: naving)
References
Details
(Keywords: verifyme, Whiteboard: [nsbeta1+][pDT+])
Attachments
(2 files)
841 bytes,
patch
|
Details | Diff | Splinter Review | |
2.42 KB,
patch
|
Details | Diff | Splinter Review |
A Japanese user reported he often failed to get new messages from POP server. POP3 log is the following: 0[344048]: Entering NET_ProcessPop3 21 0[344048]: POP3: Entering state: 1 0[344048]: POP3: Entering state: 2 0[344048]: POP3: Entering state: 4 0[344048]: RECV: (null) 0[344048]: POP3: Entering state: 29 0[344048]: POP3: Entering state: 24 0[344048]: POP3: Entering state: 25 "RECV: (null)" is strange. But if he connect the POP server by telnet command, he gets "+OK <mail server> POP3 server ready". http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=987
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Could you try this patch or ask that japanese user to try this patch, if possible. I think command_succeeded should be set to TRUE even when we receive null so that the subsequent commands are sent. nominating
Keywords: nsbeta1
Reporter | ||
Comment 3•23 years ago
|
||
Isn't it neccesary to receive "+OK <mail server> POP3 server ready"? The original reporter said he received it if he connected the server by telnet command. I can't reproduce this bug, but I modified nsPop3Protocol.cpp as follows: ********************************* if(line && *line == '+') { if(PL_strlen(line) > 4) m_commandResponse = line+4; else m_commandResponse = line; } m_pop3ConData->command_succeeded = PR_FALSE; ********************************* And I got the same log as the original reporter's. ********************************* 1024[805faf8]: Entering NET_ProcessPop3 57 1024[805faf8]: POP3: Entering state: 1 1024[805faf8]: POP3: Entering state: 2 1024[805faf8]: POP3: Entering state: 4 1024[805faf8]: RECV: +OK <mail server> POP3 server ready (ESIZE/jetstar) 1024[805faf8]: POP3: Entering state: 29 1024[805faf8]: POP3: Entering state: 24 1024[805faf8]: POP3: Entering state: 25 ********************************* I think command_succeeded should be set to FALSE if "+" isn't returned.
Reporter | ||
Comment 4•23 years ago
|
||
The problem is why Mozilla can't get "+OK <mail server> POP3 server ready".
Assignee | ||
Comment 5•23 years ago
|
||
Try my patch, it is the correct thing to do here.
Reporter | ||
Comment 6•23 years ago
|
||
OK, please check in the patch. The original reporter doesn't have a build environment.
Assignee | ||
Comment 7•23 years ago
|
||
Could I get a test account on that server to verify this patch, thanks!
Reporter | ||
Comment 8•23 years ago
|
||
No, the server is within his company's LAN and not accessible from outside.
Comment 9•23 years ago
|
||
Navin, If we don't receive +OK at this point, what happens next with the code that you changed? Does it keep waiting until it gets it? If so, at what point does it stop waiting?
Assignee | ||
Comment 10•23 years ago
|
||
Assignee | ||
Comment 11•23 years ago
|
||
We want to waitforStartofconnectionResponse only when we start a new connection That is the only time the server would send us +Ok..... If the user types a wrong password, then we are basically using the same connection so set the next state to after FINISH_CONNECT. cc bienvenu for review. I want to get this checked in for 0.9.1
Comment 12•23 years ago
|
||
I really don't know this code and I'm a little afraid of changing this so late. Is this a recent regression? Can you get mscott to look at it?
Reporter | ||
Comment 13•23 years ago
|
||
0.8 works fine, but 0.9 has this bug.
Assignee | ||
Comment 14•23 years ago
|
||
I had changed some code to make the password dialog to come up again and again and it caused this problem. But I am pretty sure this is correct thing to do here while still allowing the pwd dialog to come up again and again. When we make a connection we get +Ok.. from the server. So we need to wait for the response if we receive null. But we don't need to repeat this step (waitforStartofconnectionResponse) if we are resending the password on the same connection because the server will only send null and nothing else. mscott is away on vacation but i can wait for him to come back.
Updated•23 years ago
|
Priority: -- → P1
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
Comment 15•23 years ago
|
||
sr=mscott
Comment 16•23 years ago
|
||
r=bienvenu, but make sure you've tested the various permutations of pop get new mail (cancelling password prompt, invalid password, etc).
Assignee | ||
Comment 18•23 years ago
|
||
I have tested all combinations of Getting New mail, Cancel password and invalid password.
a=dbaron for trunk checkin (on behalf of drivers) I was a little worried about this one (as I said in email yesterday), which is why I didn't approve it yesterday. It appeared to me like a nontrivial change in core-level code, although the bug it's fixing also seems quite serious so it's certainly worthy of approval even if somewhat risky, assuming it's well tested. In an approval request (or, better, in comments on the bug cited in the approval request), it's often nice to read a little (say, a sentence or two) about the risk involved in a patch when it's not obvious. The drivers certainly don't have detailed knowledge about all the code in Mozilla, so it's helpful to give a knowledgable opinion about what the risk is (for example, what possible regressions it could cause and how well the code has been tested). Anyway, please watch for any possible regressions... FWIW, this comment seems backwards: + m_pop3ConData->pause_for_read = PR_TRUE; /* don't pause */
Assignee | ||
Comment 20•23 years ago
|
||
fix checked in. kazhik@mozilla.gr.jp, please verify this bug with tomorrow's trunk build.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 21•23 years ago
|
||
reporter, Can you please verify this bug since this problem is seen on one of your internal pop servers. Thanks.
Keywords: verifyme
Reporter | ||
Comment 22•23 years ago
|
||
The original reporter said he could get messages from POP server now. Verifying.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•