836358 - Text on doorhanger buttons is harder to read

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Since we switched to the Holo Light theme the text on doorhanger buttons is harder to read (black on dark grey).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I didn't mean to assign this to myself.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - Can you take a look at this? It's a light theme regression.

Hmm, could you reduce the font size a bit too? See bug 715572

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: screenshot

Example of the problem

Comment 4

[Sriram Ramasubramanian [:sriram]]

The buttons are created in Java. Unfortunately we cannot set a style there. We can, ofcourse, change the text color and the text size. But the background is provided by the OS. (Ya! we should change it). So, on HTC, it might be different than what's in Samsung. Until we rely on OS to give us a generic button, we cannot change any attribute here.

There is a new design floating around. That would make us add our own custom button -- where we can control everything.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Created attachment 709208 [details]
> screenshot
> 
> Example of the problem

This is what I see as well. And actually this is not bad; for some reason I thought it was worse when I filed it. Feel free to WORKSFORME this bug.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree with Kats