Closed Bug 836391 Opened 11 years ago Closed 11 years ago

fsmdef.c sends back the wrong error for create answer

Categories

(Core :: WebRTC: Signaling, defect, P5)

21 Branch
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: abr, Assigned: abr)

References

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

In fsmdef.c, under fsmdef_ev_createanswer(), the following code is used to check for successful retrieval of ICE parameters:

>    vcm_res = vcmGetIceParams(dcb->peerconnection, &ufrag, &ice_pwd);
>    if (vcm_res) {
>        FSM_DEBUG_SM(DEB_F_PREFIX"vcmGetIceParams returned an error\n",
>            DEB_F_PREFIX_ARGS(FSM, __FUNCTION__));
>      ui_create_offer(evCreateAnswerError, line, call_id,
>          dcb->caller_id.call_instance_id, strlib_empty());
>      return (fsmdef_release(fcb, cause, FALSE));
>    }

The "ui_create_offer()" should be "ui_create_answer()". This is unlikely to show up in actual use, as the call to get ICE parameters is very unlikely to fail.
Depends on: 860012
Fixed with the landing of Bug 860012
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.