836546 - Simplify gray links in the GC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I had to make some changes to this code for the zones work, and I realized that we can simplify it. I don't think we need to worry about debugger objects being in the list. We're supposed to be putting debugger objects in the same group and the objects they point to. Assuming we do this correctly, we'll never have to cross groups for debugger objects.

I'm thinking maybe it seemed like we needed this code because the grouping code didn't always correctly put the debugger stuff in the same group. Before that code was working, it probably looked like we might have debugger objects crossing into other groups.

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 708362 [details] [diff] [review]
patch

Review of attachment 708362 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that's much better!

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b53112a2a23

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b53112a2a23