836547 - Remove obsolete AITC integration in Webapps.jsm

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Richard Newman [:rnewman]]

Follow-on from Bug 836395.

Fabrice, please move to the correct component if I messed that up!

Comment 1

[[:fabrice] Fabrice Desré]

Marco, can you do that before we land bug 909573?

Comment 2

[Marco Castelluccio [:marco]]

Attachment: remove_aitc_webappsjsm

Comment 3

[Marco Castelluccio [:marco]]

Attachment: remove_aitc

Do we want also to completely remove the code under sync/ ?

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Marco Castelluccio [:marco] from comment #3)
> Created attachment 796235 [details] [diff] [review]
> remove_aitc
> 
> Do we want also to completely remove the code under sync/ ?

Yes, it's obsolete and doesn't support half of what we need.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 796235 [details] [diff] [review]
remove_aitc

Review of attachment 796235 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: this is not aitc, but an apps sync engine.

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 796233 [details] [diff] [review]
remove_aitc_webappsjsm

Review of attachment 796233 [details] [diff] [review]:
-----------------------------------------------------------------

Less code is good news!

Comment 7

[Marco Castelluccio [:marco]]

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=f5e44962f81d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/38dde25713db
https://hg.mozilla.org/integration/fx-team/rev/1cc435abcc52

I used the Try push to figure out what commit message the second patch should have since both attached patches were the same.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/38dde25713db
https://hg.mozilla.org/mozilla-central/rev/1cc435abcc52