836889 - [SM] Composition: Add keyboard shortcuts for Zoom (Ctrl++, Ctrl+-, Ctrl+0: ux-consistency with message reader), change shortcuts for font size to Ctrl+<, Ctrl+>; result of TB bug 738194

Status: NEW

(SeaMonkey :: MailNews: Composition, defect)

Description

[Michael Carr]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15.1
Build ID: 20130118191213

Steps to reproduce:

Font Zoom in SeaMonkey Composer behavior changed and 
SeaMonkey documentation no longer correctly documents Font Zoom in Composer.

Specifically, these NO LONGER WORK in SeaMonkey Composer:
o Decrease Font Size
    Ctrl+- (minus sign)
o Increase Font Size
    Ctrl++ (plus sign)

I noticed the change in SeaMonkey Composer a while back and thought it might self-correct, but it didn't--silly me!!!


Actual results:

After research I found the BUG was actually on-purpose change in Thunderbird and I assumed it was 100% carried over into SeaMonkey. 

But that was not the case as ...

ThunderBird COMPOSER changes may have broken SeaMonkey behavior:
here is the reply to my post on the issue (the same bug, but under Thunderbird):

https://bugzilla.mozilla.org/show_bug.cgi?id=738194
--- Comment #50 from :aceman <[e-mail]> 2013-01-31 06:26:25 PST ---
This bug is for Thunderbird only, so it can stay closed (reopening could make a mess in which patch landed in which TB version). 

*** But I see we could have changed/broken stuff for Seamonkey :(   *** 
I touched the file
editor/ui/locales/en-US/chrome/composer/editorOverlay.dtd 
with the key definitions and that one may be shared. 

*** Please file a separate bug for your report, thanks. ***


Expected results:

TWO BUGS RELATED TO THE IMPLEMENTED ZOOM CHANGES in SeaMonkey COMPOSER:

*** I can only report what happens in WINDOWS version ***

o SeaMonkey 2.15.1 > COMPOSER does not implement:
CTRL+, (aka, CTRL+<) *** does NOT work--PLEASE FIX ***
whereas the following examples all work as per new expectations (at least in Thunderbird and I assume also meant for SeaMonkey):
CTRL+. (aka, CTRL+>) works fine
CTRL+SHIFT+, (aka, CTRL+SHIFT+<) works fine
CTRL+SHIFT+. (aka, CTRL+SHIFT+>) works fine
CTRL++ does not work--I guess this is the new way things are
CTRL+- does not work--I guess this is the new way things are

o SeaMonkey 2.15.1 HELP > COMPOSER SHORTCUTS > contains OUTDATED DOCUMENTATION (that wastes a lot of time for folks like me who look at HELP before filing BUG reports):
Decrease Font Size
    Ctrl+- (minus sign)
    Cmd+- (minus sign)
    Ctrl+- (minus sign)
Increase Font Size
    Ctrl++ (plus sign)
    Cmd++ (plus sign)
    Ctrl++ (plus sign)

Comment 1

[Phoenix]

Confirming problem, either shortcuts or documentation must be changed (first preferable, imo)

Comment 2

[Axel Grude [:realRaven]]

Now that the keyboard shortcuts CTRL+> and CTRL+< are taken, it breaks my Addon Zombie keys - is there any way to disable these with about:config? What would be the general advice for Addon authors who absolutely depend on keyboard shortcuts - is there a way to disable built in ones at run time?

Comment 3

[Philip Chee]

(In reply to Axel Grude [:realRaven] from comment #2)
> Now that the keyboard shortcuts CTRL+> and CTRL+< are taken, it breaks my
> Addon Zombie keys - is there any way to disable these with about:config?
> What would be the general advice for Addon authors who absolutely depend on
> keyboard shortcuts - is there a way to disable built in ones at run time?

You could try Keyconfig. Several addons also package the Keyconfig core files as well.

Comment 4

[Michael]

Where can I write when in GERMAN SeaMonkey the keyboard-shortcuts are not working correctly or one letter is given to 2 functions?
One Example: In mails [ALT+A] is for "Ansicht" (View) AND "Anhänge" (attachments).

Comment 5

[Thomas D. (:thomas8)]

(In reply to Michael from comment #4)
> Where can I write when in GERMAN SeaMonkey the keyboard-shortcuts are not
> working correctly or one letter is given to 2 functions?
> One Example: In mails [ALT+A] is for "Ansicht" (View) AND "Anhänge"
> (attachments).

Hi Michael, sorry for coming back to you late but I just stumbled upon your comment here. We call the Alt+... key combinations "access keys", which is slightly different from "shortcut keys". Yes, access keys depend on localization (UI language). Please file a new bug and include something like "[de]" or "[German localization]" in the summary of your bug. We'll then push it into the right product/component.

> One Example: In mails [ALT+A] is for "Ansicht" (View) AND "Anhänge"

Michael, do you still see that bug in the current version of TB (pls state version No.)? We definitely need to disentangle that, with a view to bug 1428631 and friends, where - as an exception to the general policy - we're using the access key for attachments (Anhänge) as a shortcut key for both accessing and toggling the attachment pane between shown and hidden state. So it's crucial that the access key for attachments is identical with the shortcut key, and that it does not conflict with a main menu access key. It is the duty of localizers to prevent such conflicts.