836952 - need to accept coordinates for single_tap/double_tap

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Right now, we can do:

element.single_tap()
element.double_tap()

but we'd like to do be able to do

element.single_tap(x, y)
element.double_tap(x, y)

where (x,y) are some coordinates relative to the top left of the element.

Comment 1

[Ann(Yiming)]

Attachment: adding coordinates

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 709226 [details] [diff] [review]
adding coordinates

Review of attachment 709226 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/unit/test_touch.py
@@ +11,5 @@
>  class testTouch(MarionetteTestCase):
>      def test_touch(self):
>        testTouch = self.marionette.absolute_url("testTouch.html")
>        self.marionette.navigate(testTouch)
>        button = self.marionette.find_element("id", "mozLink")

Shouldn't we be using "mozLinkPos" here?

AFAIK, this shouldn't pass with mozLink. If it does, it's somehow tapping mozLink even though the tap gesture isn't near the element. Can you verify that mozLink doesn't work?

Comment 3

[Ann(Yiming)]

Attachment: small fix

The test looks for the element mozLink, then it calls single_tap(0,300) on the element. The new coordinates are actually on the element mozLinkPos instead of mozLink. So mozLinkPos got tapped. Though users are unlikely to do things like this, but in our tests, we want to make sure the coordinates are calculated accurately.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 710308 [details] [diff] [review]
small fix

Review of attachment 710308 [details] [diff] [review]:
-----------------------------------------------------------------

thanks! I'll land it soon

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

landed in mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53c091a119ed

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/53c091a119ed

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 710308 [details] [diff] [review]
small fix

Review of attachment 710308 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is needed to land bug 836375 in mozilla-b2g18. It's for will be very helpful for testing and only affects the Marionette test framework.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
This adds some features to marionette, and we can't land other testing features without it.
Test-only and no user impact.
String or UUID changes made by this patch:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/39453c2354dd

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0b946dd5ed67