837146 - Disable mailbloat on Mac Debug builds due to perma red (to enable comm-esr17 nightly builds to run)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

All the other comm-esr17 branches have them, so we should have them to.

Comment 1

[[e-mail] (:bhearsum)]

Weirdly, enable_nightly is already set to true. Dunno why we aren't getting them.

Comment 2

[[e-mail] (:bhearsum)]

There's permared, hidden, mac debug builds. That's why wer'e not getting nightlies. https://tbpl.mozilla.org/?tree=Thunderbird-Esr17&noignore=1

Comment 3

[Mark Banner (:standard8)]

Attachment: Disable leak tests on mac debug builds

We've had perma red on these builds for a while, plus they don't tend to give us stuff. However its just the leak test bit - the builds are still fine and the debug mozmill/xpcshell still run.

So lets turn off the leak test step. If at some time we get around to debugging them, then we can perhaps turn them back on again.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 709117 [details] [diff] [review]
Disable leak tests on mac debug builds

http://hg.mozilla.org/build/buildbot-configs/rev/231b30d5adb3

Comment 5

[Mark Banner (:standard8)]

Attachment: Don't define leak_target globally

Looks like the previous patch didn't work, the leak tests are still run on Mac debug.

This should do it though - stop defining leak_target globally, and let the platforms decide if to define it or not.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 709653 [details] [diff] [review]
Don't define leak_target globally

I think this will turn it off everywhere with the current implementation...

http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1110

should be changed to look at pf['leak_target'] instead of config['leak_target']. Then we can define this per-platform.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 709653 [details] [diff] [review]
Don't define leak_target globally

Thanks for the hint, I checked in both:

http://hg.mozilla.org/build/buildbotcustom/rev/f7e9b171d2c9
http://hg.mozilla.org/build/buildbot-configs/rev/ecd94170d162

Comment 8

[Justin Wood (:Callek)]

In production

Comment 9

[Mark Banner (:standard8)]

Attachment: Really disable leak tests on Mac

I totally headed down the wrong route. leak_target is just overriding the action that happens to run the actual leak tests.

What I wanted to be doing was setting enable_leaktests to false on Mac.

This patch:
- Reverts the changes to leak_target
- Removes the duplicate platform definitions for leak_target when the global config will do.
- Turns off enable_leaktests on Mac.

When landing this, I'll also backout http://hg.mozilla.org/build/buildbotcustom/rev/f7e9b171d2c9 to revert the leak_target check to using the global config.

Comment 10

[Rail Aliiev [:rail]]

in production

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 711739 [details] [diff] [review]
Really disable leak tests on Mac

Oops, forgot to mark this as landed:

http://hg.mozilla.org/build/buildbot-configs/rev/89c7b3be22f9
http://hg.mozilla.org/build/buildbotcustom/rev/9b23b69f1947

Comment 12

[Mark Banner (:standard8)]

This is live and working fine now.