837226 - Rename the |utf8| variable in MetroUtils Log function: It holds an acp-encoded (not utf8-encoded) string

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: General, defect)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1 (WIP)

The Log function in MetroUtils currently converts unicode strings to the system codepage before passing them to PR_LOG.  It should convert them to UTF8.

Attached is an untested WIP patch.

Comment 1

[Asa Dotzler [:asa]]

What does this work get us for v1 that we need?

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

This isn't necessary for v1.  The effect of this bug is likely just that certain characters will not appear correctly in some logs.

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Tim Abraldes (:tabraldes) from comment #0)
> The Log function in MetroUtils currently converts unicode strings to the
> system codepage before passing them to PR_LOG.  It should convert them to
> UTF8.

Why? I thought PR_LOG takes a string encoded in the system codepage on Windows.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> (In reply to Tim Abraldes (:tabraldes) from comment #0)
> > The Log function in MetroUtils currently converts unicode strings to the
> > system codepage before passing them to PR_LOG.  It should convert them to
> > UTF8.
> 
> Why? I thought PR_LOG takes a string encoded in the system codepage on
> Windows.

What I really meant was that the code appears to be trying to convert a utf-16 string into a utf-8 string (since the variable it stores the result in is called "utf8"), but it is actually converting it to the system codepage.  If PR_LOG expects a string encoded in the system codepage then this code does what it is supposed to do (though the variable name should be changed).

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Tim Abraldes (:tabraldes) from comment #4)
> What I really meant was that the code appears to be trying to convert a
> utf-16 string into a utf-8 string (since the variable it stores the result
> in is called "utf8"), but it is actually converting it to the system
> codepage.  If PR_LOG expects a string encoded in the system codepage then
> this code does what it is supposed to do (though the variable name should be
> changed).

Wow, |utf8| is definitely a confusing name. Please change the name, rather than the behavior.

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Updating title of bug

Comment 7

[Firefox Bug Husbandry Bot]

Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354