Closed Bug 837668 Opened 11 years ago Closed 10 years ago

[Dialer] Implement new startup loading events

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: julienw, Assigned: Eli)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=3 s= u=])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150
46 bytes, text/x-github-pull-request
hub
: review+
etienne
: review+
bajaj
: approval-gaia-v2.0+
Details | Review 
We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar.

For the Dialer, it should be triggered when a number can be dialed (ie: the touch events are registered).
Blocks: gaia-perf-measure
No longer depends on: gaia-perf-measure
Summary: "ready to use" perf measurement → [Dialer] "ready to use" perf measurement
Depends on: 837139
Keywords: perf
Whiteboard: [c=instrumentation p=]
Priority: -- → P2
Whiteboard: [c=instrumentation p=] → [c=automation p= s= u=]
Blocks: 996043
Assignee: nobody → eperelman
Whiteboard: [c=automation p= s= u=] → [c=automation p=3 s= u=]
Blocks: gaia-perf-events
Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented.
Summary: [Dialer] "ready to use" perf measurement → [Dialer] Implement new startup loading events
Status: NEW → ASSIGNED

        Attachment #8435878 -
        Flags: review?(hub)

        Attachment #8435878 -
        Flags: review?(etienne)

    
    

    
  
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Rock on!

        Attachment #8435878 -
        Flags: review?(etienne) → review+
Depends on: 1019037

    
    

    
  
I like it, but I can't give a r+ yet, as there is some side effect that the fix for bug 1019037 will address.

Cheers,

    
    

    
  
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Please wait for bug 1019037 to land before checking this in.

        Attachment #8435878 -
        Flags: review?(hub) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/d1625a4f0ea23945e0d9ead86a93cb9dbedb2638
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)

    
    

    
  
we would like to request uplift for 2.0. blocking bug is already 2.0+

risk: low
blocking-b2g: --- → 2.0?

    
    

    
  
lets do gaia approval here for 2.0.
blocking-b2g: 2.0? → ---

    
    

    
  
Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria [1].

[1] https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance

          status-b2g-v2.0:
          --- → ?
Keywords: checkin-needed

    
  

          status-b2g-v2.0:
          ? → ---

    
    

    
  
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Low risk, see comment 9.

        Attachment #8435878 -
        Flags: approval-gaia-v2.0?(bbajaj)

    
  

          status-b2g-v2.0:
          --- → affected

          status-b2g-v2.1:
          --- → fixed

    
    

    
  
Can you please help fill the approval request comment on this ?

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]: 
[String/UUID change made/needed]:
Flags: needinfo?(eperelman)

    
    

    
  
Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria.

[Feature/regressing bug #]: bug 996038
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests
[Risks and why]: Low, as there are no user-perceived changes
[String/UUID change made/needed]: n/a
Flags: needinfo?(eperelman)

        Attachment #8435878 -
        Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: