837754 - Valgrind tbpl builds are burning

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

TEST-PASS | check-sync-dirs.py | /builds/slave/m-cen-lnx64-valgrind/src/js/src/build <= /builds/slave/m-cen-lnx64-valgrind/src/build
Generating ../src/js/src/configure using autoconf
cd ../src/js/src; /usr/bin/autoconf-2.13
make: *** No rule to make target `.mkdir.done', needed by `configure'.  Stop.
+ exit 2

Full log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19381993&tree=Firefox&full=1

Regression window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=50cf5bbcb180&tochange=4e7c92906a79

Comment 1

[Mike Hommey [:glandium]]

Time to backout bug 830351 ?

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Setting NEEDINFO from Joey since he coded the patch that landed in bug 830351.

Comment 3

[Joey Armstrong [:joey]]

The catchall .mkdir.dep rule for creation w/o a directory prefix can be re-added and that should fix the problem.

Comment 4

[Joey Armstrong [:joey]]

Attachment: valgrind tbpl builds, re-add catchall mkdir dot rule

Comment 5

[Joey Armstrong [:joey]]

(In reply to Joey Armstrong [:joey] from comment #4)
> Created attachment 710858 [details] [diff] [review]
> valgrind tbpl builds, re-add catchall mkdir dot rule

Testing locally and will send through for a review shortly.

NOTE: This failure hints that something may be attempting to create dot/cwd while sitting in cwd.  Directory dep w/o specifying the path to create may be an empty directory variable.

Comment 6

[Joey Armstrong [:joey]]

Comment on attachment 710858 [details] [diff] [review]
valgrind tbpl builds, re-add catchall mkdir dot rule

Re-add the catchall mkdir dot/no directory prefix rule for valgrind/tbpl.

Comment 7

[Joey Armstrong [:joey]]

Inbound push: committed changeset 121386:cff2fa817604

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cff2fa817604