837933 - e.me background not being unset for rest of homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Screenshot

STR (intermittent)
 (1) Because of bug 837931, have homescreen misprocess touch events and jerk user back to e.me screen
 (2) User fights back onto another page with icons, where user wanted to go

The homescreen background stays in the super-dark e.me state.  See attached screenshot.

This is most likely a pre-existing race condition exposed by bug 837931.

Comment 1

[Cristian Rodriguez (:crdlc)]

Can reproduce it again after my patch? thanks

Comment 2

[Alex Keybl [:akeybl]]

Please re-nominate if this still reproduces.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I've still be able to reproduce this after swiping away quickly from e.me when it starts loading.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

There are not problems related to touch events or something like that. Basically when ev.me is loaded they show the super dark overlay without knowing if ev.me is or not on viewport :) Fix very simple, only one line. Thanks for detecting the problem Chris

Comment 5

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/6824f39e30708015c2c25250b0619a656e120465

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 718348 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): no regression
User impact if declined: users go to landing page from ev.me while it is loading, all homescreen gets dark 
Testing completed: 
Risk to taking this patch (and alternatives if risky): null (only one if statement)
String or UUID changes made by this patch:

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 6824f39e30708015c2c25250b0619a656e120465 as:
v1-train: 60d8c4e8a468393f17fee8095ed9ecb199fc9d4e