838015 - [E-Mail][User Story] Attachments total file size

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Peter Dolanjski [:pdol]]

UCID: Email-142

User Story:
As a user, I want to see the total size of files attached to an email to make it easier to determine how much data will be required to send the email.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

I am planning to work this for the current v1.1 "sprint" but have not started yet.  I'll mark this bug as 'assigned' once I do; people should feel free to snipe this one.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(turns out this is P2 and not leo+)

Comment 3

[Rob MacDonald [:robmac]]

Total file size is shown in the draft email attachment spec - https://bug838006.bugzilla.mozilla.org/attachment.cgi?id=710545

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I think LOE:L may be a high estimate since the attachment objects currently already surface a sizeEstimateInBytes attribute.  So this is just a question of having the UI tally those counts and display an aggregate number.

Comment 5

[Dominic Kuo [:dkuo]]

Andrew, I was asked to give the LOE tags on every bugs that related to leo+, and I was not sure the implementation of calculating the size of attachments in email, so I gave LOE:L first.

Sounds like it's not complex and just waiting for the UI, so feel free to change it since you know this better than me, thanks.

Comment 6

[Dylan Oliver [:doliver]]

Clearing tracking-b2g18 flag from User Story bugs. This flag is for bugs that we would take fixes for in the 1.x branch. Feature work should be officially slotted into a release instead with leo+. If this story is intended for v1.1, please nominate for leo? blocking.

Comment 7

[Rob MacDonald [:robmac]]

The latest email attachment flows, showing total file size, have been moved to Dropbox:

https://www.dropbox.com/s/5giljes7ao9gyrg/email-attachments.pdf

The display of the size units is TBD, but if anyone has an existing reference, feel free to forward it to me.

Thanks!

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think it's great that we can have attachments!  Pretty exciting stuff.

I was wondering about the flow... do you have to click on the attachment section again to add another picture, attachment, etc?  Or is there going to be a way to do a multiple attachment of pictures/contacts/etc? without having to go back to the email?

I really like the total size idea as well as the progress bars for downloading the attachments.

Comment 9

[Rob MacDonald [:robmac]]

(In reply to Naoki Hirata :nhirata from comment #8)
> I was wondering about the flow... do you have to click on the attachment
> section again to add another picture, attachment, etc?  Or is there going to
> be a way to do a multiple attachment of pictures/contacts/etc? without
> having to go back to the email?

Thanks, Naoki...

For now the idea is you can only select one file at a time. So, if a user wants to have multiple attachments, they would have to tap on the plus button from inside of the email compose screen and repeat the attachment flow a second time.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://moztrap.mozilla.org/manage/case/6921/ created.  
A couple of visual bugs in terms of alignment filed.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

More test cases will come later with other attachment type implementations.

Comment 12

[Rob MacDonald [:robmac]]

Reposting link to spec in dropbox as it appears to have been broken...

https://www.dropbox.com/s/c9rrz0ymxvg0osw/email-attachments.pdf

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

needed to be +'d for 1.1 work since its a feature/user story

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

-- Mass Edit -- 
These user stories are not P1, therefore not blockers to shipping. We will track for now and look into how to keep tabs on these going forward.

Comment 15

[Andrew Sutherland [:asuth] (he/him)]

This was implemented for v1.1 as part of bug 838006.