838110 - Wallpaper customization

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kai-Chih Hu [:khu]]

For customization. 

Need to make sure wallpaper is included in customization mechanism. This case is used for the 1st customized release. Detailed works could be explained in this Bugzilla case. 

Also, need to get pre-defined wallpaper from partners.

Comment 1

[David Palomino [:dpalomino]]

cc'ing Beatriz and Daniel. Nominating as tef?

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

In triage with Daniel - this doesn't block since it can be worked around in build-time configuration workaround so we're only tracking here given that understanding.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

some work is still needed to enable customize-ability.
Yuren can you provide your approach so what you do can land into v1.0.1? Thanks

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

1. now we hard code wallpaper list in html, we need to use a JSON file for description of wallpaper file list
2. I plan to add a parameter CUSTOMIZE in build script, we will copy customize wallpapers to wallpaper app on build time if CUSTOMIZE is assigned a customize folder.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request

https://github.com/mozilla-b2g/gaia/pull/8233

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking then, if this is work needed to allow partner's to build-time customize.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: sample customize package

sample customize package, unzip it and use below command to apply it:
CUSTOMIZE=<CUSTOMIZE_PATH> make reset-gaia

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: screenshot for sample customize package

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.

master:
https://github.com/mozilla-b2g/gaia/commit/99d513f89bf45f35fb4035a1dab2918eb828c7c6

v1.0.1:
https://github.com/mozilla-b2g/gaia/commit/5691a16fff8e1403c75ed9d6f3a443b7e58198c6

v1-train:
https://github.com/mozilla-b2g/gaia/commit/ae005e3598c1b7d74838e0831430a2d18cb3a7a0

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Per comment 9, setting flags appropriately.

Comment 11

[Deepa Subramanian]

"Can you please provide steps to verify this fix - as we will blackbox test from the UI?"

Comment 12

[sarsenyev]

Environmental  Variables:
Unagi Build ID: 20130403070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/512258bc00a3
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7

Environmental  Variables:
Unagi Build ID: 20130403070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d467369d1b0c
Gaia: 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75

Verify on "Unagi" wallpaper customization.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Bug was not verified properly.  Will verify later.  The verification requires to make a customized gaia, which would not be in any of our current mozilla builds.

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified custom : wallpaper, ringtone, browser bookmarks, startup screen, call support.

customized Contacts doesn't seem to work, sms-blacklist.json and preset settings didn't seem to work.  IS this suppose to be the case?

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I guess this is specifically for wallpapers, so I will mark this verified.

Using gaia commit ff8832264853209b688797176bb2f3a3866aa4c0
MOZILLA_OFFICIAL=1 GAIA_DISTRIBUTION_DIR=distribution/ make reset-gaia

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Naoki, all customization work should be work, so please help to file bugs if anything can't work. thanks :)