838622 - [Dialer] USSD unit tests are failing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

I have just realized that the USSD/MMI tests are failing, more concretely from

[communications] Call forwarding request via MMI. Active voice

    [communications] Check call forwarding rules ‣

    Error: TypeError: navigator.mozL10n.keys is not a function (http://communications.gaiamobile.org:8080/dialer/test/unit/ussd_test.js?time=1360163574152:196)
        at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959)

on.

In fact, it is kind of weird since the suite "Call forwarding request via MMI. Active voice" ( https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/test/unit/ussd_test.js#L188 ) uses variables which are not declared or in scope.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

I assigned the bug to you, Fernando, just because git blames you... :-p We can discuss about what should be tested there and I could take care of fixing it ;-)

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

(In reply to gtorodelvalle from comment #1)
> I assigned the bug to you, Fernando, just because git blames you...

git blames me for writing the tests, not for breaking them. This used to work. I'll take a look at them as soon as I can.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

You are absolutely right!!! :-D My bad ;-) Filling a feature request to Github to add "git test-breaker-blame" :-p Thanks!

Comment 4

[Mike Pennisi [:jugglinmike]]

Hey guys,

I'm disabling these tests as part of https://bugzilla.mozilla.org/show_bug.cgi?id=838993 . My intention is to begin fixing and re-enabling them after that.

Would you mind updating this bug to block 838993 ?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Sure! Thanks Mike!

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8107

Pointer to Github pull-request

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 713948 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8107

Thanks for the work Fernando!

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/362518d356ca32b40c2fbbcc26d48e679e34fd97

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Evolving it to RESOLVED-FIXED since the pull request already merged ;-) Thanks!

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 898646aa9cfb3307c964c9e028acd683b601bd27
v1.0.1: 5e064fb4cc31efc69bf173d50e4b8bdca9247598

Comment 11

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

You can run the communications/dialer/test/unit/ussd_test.js tests using the test-agent as described in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Testing/Gaia_unit_tests

Comment 13

[amiller]

No need to create a TC in Moztrap for this issue.

Comment 14

[Darren]

Cannot verify, do not have tools to test this issue.