Closed
Bug 839033
Opened 11 years ago
Closed 11 years ago
Convert HTMLProgressElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: baku, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
13.46 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
5.72 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
3.94 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #711288 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #711289 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #711289 -
Attachment is obsolete: true
Attachment #711289 -
Flags: review?(Ms2ger)
Attachment #711294 -
Flags: review?(Ms2ger)
Updated•11 years ago
|
Attachment #711288 -
Flags: review?(Ms2ger) → review+
Updated•11 years ago
|
Attachment #711294 -
Flags: review?(Ms2ger) → review+
Comment 4•11 years ago
|
||
I think it's better to implement it this way.
Attachment #711321 -
Flags: review?(mounir)
Assignee | ||
Comment 5•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b4df40ac97da green on try.
Updated•11 years ago
|
Attachment #711321 -
Flags: review?(mounir) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd86a8178cec https://hg.mozilla.org/integration/mozilla-inbound/rev/e8b847157094 https://hg.mozilla.org/integration/mozilla-inbound/rev/cf285bf3c6fc
Flags: in-testsuite?
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Backed out for build bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/f8e8b2be32e6 https://tbpl.mozilla.org/php/getParsedLog.php?id=19611157&tree=Mozilla-Inbound HTMLSharedElement.cpp rm -f libgkcondash_s.a /builds/slave/m-in-osx64/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/m-in-osx64/build/config/expandlibs_gen.py --depend .deps/libgkcondash_s.a.desc.pp -o libgkcondash_s.a.desc DASHDecoder.o DASHRepDecoder.o DASHReader.o /usr/local/bin/ccache /builds/slave/m-in-osx64/build/clang/bin/clang++ -arch i386 -o SVGAnimateMotionElement.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -D_IMPL_NS_LAYOUT -I/builds/slave/m-in-osx64/build/content/svg/content/src -I. -I../../../../dist/include -I/builds/slave/m-in-osx64/build/obj-firefox/i386/dist/include/nspr -I/builds/slave/m-in-osx64/build/obj-firefox/i386/dist/include/nss -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../xml/content/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../dom -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../base/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/generic -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/xul/base/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/svg -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/style -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../events/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../html/content/src -I/builds/slave/m-in-osx64/build/content/xbl/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../smil -fPIC -Qunused-arguments -Qunused-arguments -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-mismatched-tags -isysroot /Developer/SDKs/MacOSX10.6.sdk -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -DNO_X11 -pipe -DNDEBUG -DTRIMMED -g -O3 -fno-omit-frame-pointer -Werror -Wno-error=uninitialized -Wno-error=deprecated-declarations -Qunused-arguments -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MF .deps/SVGAnimateMotionElement.o.pp /builds/slave/m-in-osx64/build/content/svg/content/src/SVGAnimateMotionElement.cpp SVGAnimationElement.cpp ../../../../../../content/html/content/src/HTMLProgressElement.cpp:131:1: error: control reaches end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated. make[9]: *** [HTMLProgressElement.o] Error 1
Assignee | ||
Comment 8•11 years ago
|
||
a |return NS_OK;| was missing.
Attachment #711321 -
Attachment is obsolete: true
Attachment #712384 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Oops, sorry.
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcff3820f704 https://hg.mozilla.org/integration/mozilla-inbound/rev/ecbca463ce66 https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1aa2cbe096
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bcff3820f704 https://hg.mozilla.org/mozilla-central/rev/ecbca463ce66 https://hg.mozilla.org/mozilla-central/rev/0a1aa2cbe096
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•