839236 - Plugin Hang UI: Missing nsRefPtr in PluginModuleParent::GetPluginName

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

While running my new unit tests in bug 826851, I found leakage due to a missing nsRefPtr.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Adds missing nsRefPtr to nsPluginHost::GetInst call

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Adds missing nsRefPtr to nsPluginHost::GetInst call Rev. 2

Rev 2, removes some extra stuff that shouldn't have been in there

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 711488 [details] [diff] [review]
Adds missing nsRefPtr to nsPluginHost::GetInst call  Rev. 2

Review of attachment 711488 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +533,5 @@
>  bool
>  PluginModuleParent::GetPluginName(nsAString& aPluginName)
>  {
> +    nsRefPtr<nsPluginHost> host = 
> +        already_AddRefed<nsPluginHost>(nsPluginHost::GetInst());

You could use |dont_AddRef(nsPluginHost::GetInst())| here instead.

Comment 4

[Benjamin Smedberg]

Comment on attachment 711488 [details] [diff] [review]
Adds missing nsRefPtr to nsPluginHost::GetInst call  Rev. 2

Yeah, use dont_AddRef here. r=me with that

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Adds missing nsRefPtr to nsPluginHost::GetInst call Rev. 3

Carrying forward r+
Try build is https://tbpl.mozilla.org/?tree=Try&rev=a49d1a6c54f6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/244daeec3393

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/244daeec3393