839272 - Re-enable WebRTC when bug 837618 is fixed

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Bug 839046 temporarily disabled WebRTC as a work around for bug 837618.

Once bug 837618 is fixed, we should re-enabled WebRTC as it is something extensions might want to use.

Note: when we re-enable, we need to do more than backing out bug 839046 - we need to add the required parts to packaging as well, as currently not everything is packaged that is needed for WebRTC.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This enables webrtc, and has the side effect of fixing the bustage on trunk.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/ff64a366af33

Comment 3

[Landry Breuil (:gaston)]

Just a small headsup - this breaks packaging on platforms where webrtc is not enabled (ie the BSDs) because peerconnection files are not guarded within #ifdef MOZ_WEBRTC in mail/installer/package-manifest.in. Testing an obvious fix here, then will post a follwup patch for review.

Comment 4

[Landry Breuil (:gaston)]

Attachment: Fix packaging when MOZ_WEBRTC is not defined

Fixes the issue here, thunderbird-24.0a1.en-US.openbsd5.3-x86_64.tar.bz2 is fine with that diff

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/2592479ad475