839352 - B2G SMS & B2G MMS: clean up the chaotic terminology for |record| and |message| in MobileMessageDatabaseService.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gene Lian (I already quit Mozilla)]

The terminology is a chaos. Sometimes we use |message|, |record| and |data| to refer to the same thing but they actually have different meanings. I hope to clean them up first so that it's easier to do the following tasks for constructing the MMS database.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.1

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 711666 [details] [diff] [review]
Patch, V1.1

Review of attachment 711666 [details] [diff] [review]:
-----------------------------------------------------------------

r=me instead.

Comment 4

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80dcbc0b99e0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/80dcbc0b99e0

Comment 6

[Gene Lian (I already quit Mozilla)]

This bug relates to MMS features and needs to be tagged as leo+ so that we can uplift it into the b2g-18 branch.

Comment 7

[Dylan Oliver [:doliver]]

Leo triage: leo+ for MMS blockers

Comment 8

[Ryan VanderMeulen [:RyanVM]]

unable to find 'dom/mobilemessage/src/ril/MobileMessageDatabaseService.js' for patching
14 out of 14 hunks FAILED -- saving rejects to file dom/mobilemessage/src/ril/MobileMessageDatabaseService.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 839352

Comment 9

[Gene Lian (I already quit Mozilla)]

This one depends on Bug 831683, which needs to be checked in first.

Comment 10

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/ea3d5929ec68