839378 - video controls should not modify page DOM

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

videocontrols.xml has:
                    // Make the <video> element keyboard accessible.
                    this.video.setAttribute("tabindex", 0);

This is bad. We should not be modifying the DOM visible to the page. We need to find another way to do this.

Neil: Is there a better way to do this?

Comment 1

[Neil Deakin]

You need to override nsIContent::IsHTMLFocusable for the video element.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Don't modify the page DOM from videocontrols

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80df535bf5e6

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80df535bf5e6