84026 - hit alt key and crash

Status: VERIFIED DUPLICATE of bug 83974

(Core :: XUL, defect)

Description

[Dan M]

With a browser window open, hit the "alt" key, as if you were about to open a 
menu using a keyboard shortcut. Boom (when you let go of the key, or hit another 
key, like alt-f).

Most likely this was introduced in rev 1.74 of nsMenuBarFrame.cpp, which contains 
amusing code like this:

nsMenuBarFrame::FindMenuWithShortcut(PRUint32 aLetter) {
 ...
 GetInsertionPoint(shell, this, nsnull, &immediateParent);
 ...
}
nsMenuBarFrame::GetInsertionPoint(nsIPresShell* aShell, nsIFrame* aFrame,
                nsIFrame* aChild, nsIFrame** aResult) {
 ...
 aChild->GetContent(getter_AddRefs(child));
 ...
}

you see the problem. The call to aChild was added in rev 1.74 to fix bugs 80512 
and bug 83707. The previous rev was simply missing the call. A null check would 
seem to fix this crash, but regress those other bugs.

Comment 1

[Dan M]

*** This bug has been marked as a duplicate of 83974 ***

Comment 2

[John Morrison]

vrfy