840856 - Reproducible crash in gfxContext::gfxContext

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

This bug was filed from the Socorro interface and is 
report bp-396c999f-a64c-45d6-94a9-149df2130213 .
============================================================= 

I think this is an OOM crash but I'm sure. We're crashing on a null de-reference. My process is at about 1.5GB of RAM so we shouldn't be failing an allocation on a 64-bit mac build with 16GB of memory (8GB free).

Hosting the file since it's 18MB:
https://dl.dropbox.com/u/10523664/galaxymapgl-OOM.tar.gz

STR:
1) Open index.html, select all the stars
2) Wait for the stars to loads
3) Typically I get a crash before all the stars load but sometimes I have to reload a few times

Comment 1

[Benoit Girard (:BenWa)]

Caused by bug 593733, we don't check if the allocation succeeded or not:
http://hg.mozilla.org/mozilla-central/annotate/36525224b14e/gfx/layers/opengl/ThebesLayerOGL.cpp#l734

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

This restores the behavior before your patch landed.

Comment 3

[Benoit Girard (:BenWa)]

(In reply to Benoit Girard (:BenWa) from comment #0)
> I think this is an OOM crash but I'm sure. We're crashing on a null
> de-reference. My process is at about 1.5GB of RAM so we shouldn't be failing
> an allocation on a 64-bit mac build with 16GB of memory (8GB free).
> 

I had my build running in 32-bit mode so that explains why I was running out of memory so fast.

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ca584f4fe7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e6ca584f4fe7