Closed
Bug 840883
Opened 11 years ago
Closed 11 years ago
Update Nightly and Aurora branding with awesome new artwork.
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 25
People
(Reporter: Dolske, Assigned: shorlander)
References
Details
Attachments
(3 files, 11 obsolete files)
4.99 MB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
5.27 MB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
4.11 MB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Martell did a fantastic update of the Nightly planet a while back, but looks like we're only using that in the stub installer. Compare: https://mxr.mozilla.org/mozilla-central/source/browser/branding/nightly/bgintro.bmp with https://mxr.mozilla.org/mozilla-central/source/browser/branding/nightly/content/about-background.png The old style Nightly planet has pale-yellow glowy simple dots representing cities along transit lines, whereas the new Nightly planet has more orangeish cities, with paths that are more gradienty. Yes, gradienty. It would be nice to update all the Nightly branding with this change, it's all under https://mxr.mozilla.org/mozilla-central/source/browser/branding/nightly/ We could do this as a series of steps to spread out the work, if that helps. Should just be all straight-up image replacements, but there are a number of visual variations in the branding, as well as multiple image formals to deal with (png, bmp, icns, etc). So, trivial in general but a little tedious to actually _do_. Sean points out that the latest sexy is at https://assets.mozillalabs.com/Brands-Logos/Firefox/logo-only/ Unf unf.
I've also filed bug 734133 concerning new icons some time ago.
Assignee | ||
Comment 2•11 years ago
|
||
I started working on this a while back and finished almost all of the Nightly icon update. Things slowed down a little trying to get the correct rendering for 32x32 and 16x16 versions. I might be able to get back on it soon-ish but if someone else wants to take it on in the mean time I can post what I have so far.
Assignee | ||
Comment 3•11 years ago
|
||
Going to upload an Aurora patch also. Splitting since the patches are pretty large.
Attachment #713447 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Summary: Update Nightly branding with awesome new artwork. → Update Nightly and Aurora branding with awesome new artwork.
Assignee | ||
Updated•11 years ago
|
QA Contact: shorlander
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → shorlander
QA Contact: shorlander
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
Update Nightly branding. Changes the OS X DMG Applications symlink from a space to Applications.
Attachment #766008 -
Attachment is obsolete: true
Attachment #769016 -
Flags: review?(dolske)
Assignee | ||
Comment 5•11 years ago
|
||
Updates Aurora branding.
Assignee | ||
Updated•11 years ago
|
Attachment #769017 -
Flags: review?(dolske)
Assignee | ||
Comment 6•11 years ago
|
||
Updates Unofficial branding. Changes MOZ_APP_DISPLAYNAME from MozillaDeveloperPreview to Nightly so we can use the official wordmark in the Nightly branding dir.
Attachment #769020 -
Flags: review?(dolske)
Reporter | ||
Updated•11 years ago
|
Attachment #769017 -
Flags: review?(dolske) → review+
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 769016 [details] [diff] [review] Update Nightly Branding - 02 - Part 1 Review of attachment 769016 [details] [diff] [review]: ----------------------------------------------------------------- Marking r+, but steven has an tweaking coming to fix the DMG (dsstore) due to re-adding the folder name. ::: browser/installer/Makefile.in @@ +100,5 @@ > ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) > MOZ_PKG_MAC_DSSTORE=branding/dsstore > MOZ_PKG_MAC_BACKGROUND=branding/background.png > MOZ_PKG_MAC_ICON=branding/disk.icns > +MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/Applications" This is the only change that's slightly more than purely visual, but seems fine. (Shouldn't be any L10N impact, since I don't expect the OS localizes the folder name due to compatibility impact.)
Attachment #769016 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Updates the .DS_Store for Official disk image so the Applications symlink icon is in the right place.
Attachment #769051 -
Flags: review?(dolske)
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #7) > > +MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/Applications" > > This is the only change that's slightly more than purely visual, but seems > fine. (Shouldn't be any L10N impact, since I don't expect the OS localizes > the folder name due to compatibility impact.) Aaaaactually. Looking at bug 320155 (which originally implemented this), it seem that OS X might be using a way to localize displayed folder names. Not sure if that's actually the case, or what happens with symlinks in DMGs, so let's consider this in a separate bug.
Assignee | ||
Comment 10•11 years ago
|
||
Undo Application symlink change
Attachment #769016 -
Attachment is obsolete: true
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #769017 -
Attachment is obsolete: true
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #769020 -
Attachment is obsolete: true
Attachment #769051 -
Attachment is obsolete: true
Attachment #769020 -
Flags: review?(dolske)
Attachment #769051 -
Flags: review?(dolske)
Assignee | ||
Updated•11 years ago
|
Attachment #769072 -
Flags: review?(dolske)
Assignee | ||
Updated•11 years ago
|
Attachment #769074 -
Flags: review?(dolske)
Assignee | ||
Updated•11 years ago
|
Attachment #769075 -
Flags: review?(dolske)
Assignee | ||
Comment 13•11 years ago
|
||
.DS_Store messed up again. Fixing.
Attachment #769072 -
Attachment is obsolete: true
Attachment #769072 -
Flags: review?(dolske)
Attachment #769222 -
Flags: review?(dolske)
Reporter | ||
Comment 14•11 years ago
|
||
Comment on attachment 769074 [details] [diff] [review] Update Aurora Branding - 02 - Part 2 Review of attachment 769074 [details] [diff] [review]: ----------------------------------------------------------------- Modified Binary File: browser/branding/aurora/disk.icns Modified Binary File: browser/branding/aurora/document.icns Modified Binary File: browser/branding/aurora/firefox.icns These files gained around 4MB total (ditto for the other branding flavors), with most (970K) of that being in the 1024x1024 (512x512@2x) version within. I'm a bit concerned about the impact on download size -- it's a lot of overhead for something that would rarely be seen at full-res, and has a direct impact on the download funnel. How about removing the largest size?
Attachment #769074 -
Flags: review?(dolske) → review+
Reporter | ||
Updated•11 years ago
|
Attachment #769222 -
Flags: review?(dolske) → review+
Reporter | ||
Comment 15•11 years ago
|
||
Comment on attachment 769075 [details] [diff] [review] Update Unofficial Branding - 02 - Part 3 Review of attachment 769075 [details] [diff] [review]: ----------------------------------------------------------------- New Binary File: browser/branding/unofficial/favicon.ico Eh? This isn't in any other dir. ::: browser/branding/unofficial/branding.nsi @@ +7,5 @@ > # The nightly build branding.nsi is located in browser/installer/windows/nsis/ > > # BrandFullNameInternal is used for some registry and file system values > # instead of BrandFullName and typically should not be modified. > +!define BrandFullNameInternal "Nightly" Hmm. I'm increasingly wary about changing this, because it can have a bunch of side-effects. Let's go ahead and land the updated image assets, but leave the name change (in branding.nsi and configure.sh) for a separate bug. Probably the same bug for changing the default build to use unofficial branding instead of nightly.
Attachment #769075 -
Flags: review?(dolske) → review-
Assignee | ||
Comment 16•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #14) > Comment on attachment 769074 [details] [diff] [review] > Update Aurora Branding - 02 - Part 2 > > Review of attachment 769074 [details] [diff] [review]: > ----------------------------------------------------------------- > > Modified Binary File: browser/branding/aurora/disk.icns > Modified Binary File: browser/branding/aurora/document.icns > Modified Binary File: browser/branding/aurora/firefox.icns > > These files gained around 4MB total (ditto for the other branding flavors), > with most (970K) of that being in the 1024x1024 (512x512@2x) version within. > I'm a bit concerned about the impact on download size -- it's a lot of > overhead for something that would rarely be seen at full-res, and has a > direct impact on the download funnel. > > How about removing the largest size? While I agree we should not bloat our file size as much as possible I think to some extent it's just the cost of Retina. As a larger problem this now affects any bitmap we add to the product. Branding is just especially bad because it has so much artwork. My proposal is we keep the largest size (512 x 512 @2x) for the application icon but remove the other @2x sizes since they are just copies of the 1x sizes. Not entirely sure how OS X handles this but it seems to work without fuzziness here. For the document icons I agree we can probably remove the largest size (maybe all of the @2x sizes?) since it probably won't ever be seen at a large size.
Assignee | ||
Comment 17•11 years ago
|
||
Ok, updated the .icns files. - Remove all but the largest @2x icon - Saved them with JPEG 2000 instead of PNG OS X seems to just do the right thing without all of the @2x icons; i.e. it picks 32x32 instead of 16x16 on Retina displays. The encoding is slightly lossy but not that noticeable and seems to be a worthwhile trade WRT to file size.
Attachment #769222 -
Attachment is obsolete: true
Attachment #770973 -
Flags: review?(dolske)
Assignee | ||
Comment 18•11 years ago
|
||
Reduced icns file size
Attachment #769074 -
Attachment is obsolete: true
Attachment #771008 -
Flags: review?(dolske)
Assignee | ||
Comment 19•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #15) > New Binary File: browser/branding/unofficial/favicon.ico > > Eh? This isn't in any other dir. Oops, not sure where that came from. > ::: browser/branding/unofficial/branding.nsi > @@ +7,5 @@ > > # The nightly build branding.nsi is located in browser/installer/windows/nsis/ > > > > # BrandFullNameInternal is used for some registry and file system values > > # instead of BrandFullName and typically should not be modified. > > +!define BrandFullNameInternal "Nightly" > > Hmm. I'm increasingly wary about changing this, because it can have a bunch > of side-effects. > > Let's go ahead and land the updated image assets, but leave the name change > (in branding.nsi and configure.sh) for a separate bug. Probably the same bug > for changing the default build to use unofficial branding instead of nightly. Reverted BrandFullNameInternal. Left the updated image for the stub installer though.
Attachment #769075 -
Attachment is obsolete: true
Attachment #771012 -
Flags: review?(dolske)
Reporter | ||
Updated•11 years ago
|
Attachment #770973 -
Flags: review?(dolske) → review+
Reporter | ||
Updated•11 years ago
|
Attachment #771008 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 20•11 years ago
|
||
Forgot to update configure.sh
Attachment #771012 -
Attachment is obsolete: true
Attachment #771012 -
Flags: review?(dolske)
Attachment #771016 -
Flags: review?(dolske)
Reporter | ||
Comment 21•11 years ago
|
||
Comment on attachment 771012 [details] [diff] [review] Update Unofficial Branding - 03 - Part 3 Review of attachment 771012 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/branding/unofficial/configure.sh @@ +1,5 @@ > # This Source Code Form is subject to the terms of the Mozilla Public > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +MOZ_APP_DISPLAYNAME=Nightly I'd prefer to do this in the other patch as well, just because I haven't looked through to see if there are surprises from doing this.
Attachment #771012 -
Attachment is obsolete: false
Reporter | ||
Updated•11 years ago
|
Attachment #771016 -
Flags: review?(dolske) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #771012 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 22•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/da675673532d https://hg.mozilla.org/integration/mozilla-inbound/rev/8434d0d61a0c https://hg.mozilla.org/integration/mozilla-inbound/rev/c5cb70165784
Flags: in-testsuite-
Keywords: checkin-needed
Comment 23•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da675673532d https://hg.mozilla.org/mozilla-central/rev/8434d0d61a0c https://hg.mozilla.org/mozilla-central/rev/c5cb70165784
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in
before you can comment on or make changes to this bug.
Description
•