Closed
Bug 840993
Opened 11 years ago
Closed 11 years ago
Improved error reporting when creating the master and dependent bugs for a project review
Categories
(bugzilla.mozilla.org Graveyard :: Extensions: MozProjectReview, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file, 1 obsolete file)
15.58 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
Originally I wrote the creation of one or more of the dependent bugs under a single eval {} which caused all dependent bugs to not be created if one or more failed. I have revised the code to wrap each individual bug creation inside it's own eval {} and therefore at least the other bugs can still be created. Also I let the user know inside the accompanying comment that an error occurred and which bug was the failing bug. Also I am adding additional information such as parent bug id in the warn message that will be recorded by Arecibo which we can use for troubleshooting when problems occur. dkl
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #713399 -
Flags: review?(glob)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #713399 -
Attachment is obsolete: true
Attachment #713399 -
Flags: review?(glob)
Attachment #713425 -
Flags: review?(glob)
Comment on attachment 713425 [details] [diff] [review] Patch to improve error handling of dependent bug creation (v2) Review of attachment 713425 [details] [diff] [review]: ----------------------------------------------------------------- r=glob by inspection, looks good! there's trailing whitespace in this patch, please remove before committing. ::: extensions/MozProjectReview/Extension.pm @@ +122,5 @@ > + { > + $component = ($params->{relationship_type} eq 'Other' > + || $params->{relationship_type} eq 'Hardware Purchase') > + ? 'General' > + : $params->{relationship_type}; nit: the indentation of the ? and : lines is wrong.
Attachment #713425 -
Flags: review?(glob) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0 modified extensions/MozProjectReview/Extension.pm Committed revision 8482. Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2 modified extensions/MozProjectReview/Extension.pm Committed revision 8553.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•